Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Users.remove_roles to remove_user_roles #175

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Change Users.remove_roles to remove_user_roles #175

merged 1 commit into from
Jun 28, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jun 28, 2019 •
edited
Loading

Changes

Change unreleased Users.remove_roles to Users.remove_user_roles

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage

@joshcanhelp joshcanhelp requested a review from a team June 28, 2019 19:14
@joshcanhelp joshcanhelp added this to the v4.8.0 milestone Jun 28, 2019
@joshcanhelp joshcanhelp changed the title Change unreleased Users.remove_roles to remove_user_roles Change Users.remove_roles to remove_user_roles Jun 28, 2019
@joshcanhelp joshcanhelp merged commit 433b519 into master Jun 28, 2019
@joshcanhelp joshcanhelp deleted the change-user-remove-roles-method-name branch June 28, 2019 19:19
@joshcanhelp joshcanhelp mentioned this pull request Jun 28, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @lbalmaceda