Speed up conditional hyperparameter imputation #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a method for this, convert the configuration into an array and replace missing values with -1.
|
Let's first check whether Frank agrees or has some concerns. |
KEggensperger
approved these changes
Feb 13, 2017
smac/smbo/local_search.py
Outdated
| acq_val_incumbent = self.acquisition_function( | ||
| incumbent_.get_array(), | ||
| *args) | ||
| incumbent_ = incumbent.get_array() |
There was a problem hiding this comment.
Distinguishing between two variables with only "_" can cause a lot of confusion or needs at least a comment in the code.
mfeurer
force-pushed
the
maint/speedupincativehpimputation
branch
from
7f9e772 to
0dcbcdc
Compare
mlindauer
approved these changes
Feb 13, 2017
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a method for this, convert the configuration
into an array and replace missing values with -1.