Maint/faster one exchange neighborhood #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlindauer
requested changes
Feb 13, 2017
smac/smbo/smbo.py
Outdated
| acq_values = self.acquisition_func(imputed_configs) | ||
| config_array = np.array([x.get_array() for x in configs], dtype=np.float64) | ||
| # This imputes inactive values! | ||
| config_array[~np.isfinite(config_array)] = -1 |
There was a problem hiding this comment.
shouldn't this imputation be in a method such that we cannot forget to do it everywhere?
There was a problem hiding this comment.
This was actually introduced in PR #170 and I'm not sure why github does not update this PR. I can update this though (with yet a new pull request).
There was a problem hiding this comment.
Now the PR is updated ;)
mlindauer
approved these changes
Feb 13, 2017
|
Changes Unknown when pulling dc5131e on MAINT/faster_one_exchange_neighborhood into ** on development**. |
|
Changes Unknown when pulling dc5131e on MAINT/faster_one_exchange_neighborhood into ** on development**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.