Suppress gossip warnings due to no sampled peers (#2562)

ava-labs · Dec 29, 2023 · bbcc5f0 · bbcc5f0
1 parent 4bcf7ee
commit bbcc5f0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/network/p2p/gossip/gossip.go b/network/p2p/gossip/gossip.go
@@ -5,6 +5,7 @@ package gossip
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"sync"
 	"time"
@@ -165,7 +166,8 @@ func (p *PullGossiper[_]) Gossip(ctx context.Context) error {
 	}
 
 	for i := 0; i < p.pollSize; i++ {
-		if err := p.client.AppRequestAny(ctx, msgBytes, p.handleResponse); err != nil {
+		err := p.client.AppRequestAny(ctx, msgBytes, p.handleResponse)
+		if err != nil && !errors.Is(err, p2p.ErrNoPeers) {
 			return err
 		}
 	}

diff --git a/network/p2p/validators.go b/network/p2p/validators.go
@@ -86,6 +86,8 @@ func (v *Validators) Sample(ctx context.Context, limit int) []ids.NodeID {
 
 	v.refresh(ctx)
 
+	// TODO: Account for peer connectivity during the sampling of validators
+	// rather than filtering sampled validators.
 	validatorIDs := v.validatorIDs.Sample(limit)
 	sampled := validatorIDs[:0]