Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress gossip warnings due to no sampled peers #2562

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Suppress gossip warnings due to no sampled peers #2562

merged 1 commit into from
Dec 29, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Suppresses:

WARN ... gossip/gossip.go:337 failed to gossip {"error": "no peers"}

As the error is currently expected.

How this works

  • Checks for ErrNoPeers before reporting an error from PullGossiper.Gossip.
  • Adds a TODO to more accurately sample the requested number of validators.

How this was tested

  • CI
  • Running a local 5-node network

@StephenButtolph StephenButtolph added bug Something isn't working monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking labels Dec 29, 2023
@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Dec 29, 2023
@StephenButtolph StephenButtolph self-assigned this Dec 29, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 29, 2023
Merged via the queue into dev with commit bbcc5f0 Dec 29, 2023
17 checks passed
@StephenButtolph StephenButtolph deleted the fix-gossip-log branch December 29, 2023 07:35
pull bot pushed a commit to AKAJOKER2/avalanchego that referenced this pull request Jan 1, 2024
@coffeeavax @StephenButtolph
Add X-chain mempool data structure (ava-labs#2562)
20fd70c 
Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-kim joshua-kim joshua-kim approved these changes

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@danlaine danlaine Awaiting requested review from danlaine

Assignees

@StephenButtolph StephenButtolph

Labels
bug Something isn't working monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.18
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @dhrubabasu @joshua-kim