tmpnet: Separate network into orchestration and configuration
#2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
tmpnet-refactor-network
branch
from
7c2ca56 to
c36886d
Compare
marun
force-pushed
the
tmpnet-refactor
branch
from
d49d6f4 to
7d3474d
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
4 times, most recently
from
77139c8 to
227ed81
Compare
marun
force-pushed
the
tmpnet-refactor
branch
from
7d3474d to
282f77d
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
2 times, most recently
from
e46d2e2 to
f1cf61c
Compare
marun
changed the title
tmpnet: Separate network into orchestration and configuration
marun
force-pushed
the
tmpnet-refactor
branch
from
282f77d to
6b22969
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
5 times, most recently
from
1fa086e to
75f3b99
Compare
marun
force-pushed
the
tmpnet-refactor
branch
from
6b22969 to
d4e2f67
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
from
75f3b99 to
0a5764e
Compare
marun
force-pushed
the
tmpnet-refactor
branch
from
c6f2252 to
969b064
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
2 times, most recently
from
e09de33 to
c40f346
Compare
marun
force-pushed
the
tmpnet-refactor
branch
from
969b064 to
5b9bf79
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
from
c40f346 to
5925f98
Compare
6 tasks
marun
force-pushed
the
tmpnet-refactor
branch
from
5b9bf79 to
7c8a744
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
from
b86451d to
99eecff
Compare
marun
force-pushed
the
tmpnet-refactor
branch
from
6beb808 to
ef41e2e
Compare
marun
force-pushed
the
tmpnet-refactor-network
branch
3 times, most recently
from
80f6c63 to
f1ec505
Compare
aaronbuchwald
approved these changes
Dec 20, 2023
marun
force-pushed
the
tmpnet-refactor-network
branch
from
f1ec505 to
6939831
Compare
danlaine
approved these changes
Dec 27, 2023
tests/fixture/tmpnet/network.go
Outdated
| @@ -24,222 +23,152 @@ import ( | |||
| "github.com/ava-labs/avalanchego/utils/set" | |||
| ) | |||
|
|
|||
| // The Network type is defined in this file (network.go - orchestration) and | |||
| // network.go (reading/writing configuration). | |||
There was a problem hiding this comment.
is this a typo? Or is there another network.go file I'm missing that this is in reference to?
tests/fixture/tmpnet/network.go
Outdated
| // that an error condition will not result in a lingering process. | ||
| stopErr := node.Stop(ctx) | ||
| if stopErr != nil { | ||
| err = errors.Join(err, stopErr) |
There was a problem hiding this comment.
I don't think we need this stopErr != nil check. The spec says: "Join returns an error that wraps the given errors. Any nil error values are discarded."
marun
force-pushed
the
tmpnet-refactor-network
branch
from
6939831 to
122a88a
Compare
- Move methods to read/write network into network_config.go
marun
force-pushed
the
tmpnet-refactor-network
branch
from
122a88a to
1fda407
Compare
aaronbuchwald
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tmpnet/network.go contained methods to orchestrate networks and read and write their configuration. This PR moves reading/writing of configuration to network_config.go. The separation is intended to improve maintainability.