[x/programs] Add Engine and Store abstractions #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
|
Will this make a difference in the way programs should be written? |
samliok
previously approved these changes
Dec 19, 2023
not this PR no |
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
dboehm-avalabs
approved these changes
Jan 5, 2024
samliok
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new types
EngineandStoreand also migrates theMeterout of runtime. This PR is one of many which will move towards owning our own types and having the runtime be a simple implementation of these types[1]. This PR also greatly simplifies the runtime.Config giving it basic configurations which affect the runtime implementation. The rest of the config is now directly part of theEngine. In the context of a VM a single engine should be used for the lifetime of the program. Very similar to a gRPC client. I hope to have the time to implement this as an example into the simulator.In the previous implementation there was a 1:1 relationship between the
Engineand theStore. But as each engine can have multiple stores we can reuse the engine in circumstances where we are making program to program calls. The allows us to have more fine grained controls on all of the stores with regards to termination. As a using Stop on a single engine will terminate all child stores.[1] #631