Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/programs] Add host abstractions #658

Merged
merged 12 commits into from
Jan 6, 2024
Merged

[x/programs] Add host abstractions #658

merged 12 commits into from
Jan 6, 2024

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Dec 15, 2023 •
edited
Loading

This breaks out host related Import types into its own package.

Depends on #657

@hexfusion
Move fixtures into tests directory
c71e603 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Abstract engine from runtime
903fefe 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
React to changes
ff0adb6 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Nits
cea5ea5 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion hexfusion self-assigned this Dec 15, 2023
@hexfusion hexfusion marked this pull request as ready for review December 15, 2023 18:44
@hexfusion hexfusion changed the title [x/programs] Add host abstraction [x/programs] Add host abstractions Dec 15, 2023
samliok
samliok previously approved these changes Dec 19, 2023
View reviewed changes
x/programs/host/imports.go Outdated Show resolved Hide resolved
x/programs/host/imports.go Show resolved Hide resolved
@hexfusion hexfusion mentioned this pull request Dec 21, 2023
Merged
@hexfusion
Review comments
f25a144 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Clarify debug mode
29d3bbe 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Nit
a75af73 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Add host abstraction
3d03b4c 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
React to changes
2b7ba48 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Cleanup
3ac1a3f 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion hexfusion mentioned this pull request Dec 22, 2023
Merged
dboehm-avalabs
dboehm-avalabs previously approved these changes Jan 5, 2024
View reviewed changes
@dboehm-avalabs dboehm-avalabs enabled auto-merge (squash) January 5, 2024 18:45
samliok
samliok previously approved these changes Jan 5, 2024
View reviewed changes
@samliok samliok dismissed stale reviews from dboehm-avalabs and themself via 8559775 January 6, 2024 18:32
@patrick-ogrady patrick-ogrady merged commit 8d08faa into main Jan 6, 2024
22 checks passed
@patrick-ogrady patrick-ogrady deleted the refactor/host branch January 6, 2024 18:58
@patrick-ogrady patrick-ogrady mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dboehm-avalabs dboehm-avalabs dboehm-avalabs left review comments

@samliok samliok samliok left review comments

@patrick-ogrady patrick-ogrady Awaiting requested review from patrick-ogrady

@richardpringle richardpringle Awaiting requested review from richardpringle

Assignees

@hexfusion hexfusion

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hexfusion @samliok @dboehm-avalabs @patrick-ogrady