feat(Auth): Adding TOTP state machine actions #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2023
sebaland
reviewed
Jun 26, 2023
| logVerbose("\(#fileID) Sending event \(responseEvent)", | ||
| environment: environment) | ||
| await dispatcher.send(responseEvent) | ||
| // TODO: HS: |
There was a problem hiding this comment.
Remember to remove commented out code before releasing
There was a problem hiding this comment.
Yep.. This is something I still need to work on.. Will remove it in a follow up PR.
royjit
reviewed
Jun 29, 2023
| case .selectMFAType: | ||
| return .init(nextStep: .continueSignInWithMFASelection(challenge.getAllowedMFATypesForSelection)) | ||
| case .setUpMFA: | ||
| throw AuthError.unknown("Invalid state flow. setUpMFA is handled internally in `SignInState.resolvingTOTPSetup` state.") |
There was a problem hiding this comment.
Should we use AuthError.invalidState here?
thisisabhash
approved these changes
Jul 3, 2023
royjit
approved these changes
Jul 3, 2023
harsh62
added a commit
that referenced
this pull request
Jul 4, 2023
* feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * working on review comment
9 tasks
harsh62
added a commit
that referenced
this pull request
Jul 19, 2023
* feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * working on review comment
harsh62
added a commit
that referenced
this pull request
Jul 25, 2023
* feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * working on review comment
harsh62
added a commit
that referenced
this pull request
Aug 1, 2023
* feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * working on review comment
harsh62
added a commit
that referenced
this pull request
Aug 28, 2023
* feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * working on review comment
harsh62
added a commit
that referenced
this pull request
Aug 28, 2023
* feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * working on review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TOTP PR Number # 5
Depends on:
Changes
NOTE: The unit and integration tests will fail until all changes make it to the feature branch
(The PR is directed towards a feature branch)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.