feat(Auth): Add unit tests for TOTP #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaland
approved these changes
Jun 26, 2023
royjit
approved these changes
Jun 30, 2023
...gnitoAuthPluginUnitTests/TaskTests/ClientBehaviorTests/MFA/FetchMFAPreferenceTaskTests.swift
Show resolved
Hide resolved
thisisabhash
reviewed
Jul 3, 2023
...gnitoAuthPluginUnitTests/TaskTests/ClientBehaviorTests/MFA/FetchMFAPreferenceTaskTests.swift
Show resolved
Hide resolved
...sts/AWSCognitoAuthPluginUnitTests/TaskTests/ClientBehaviorTests/MFA/SetUpTOTPTaskTests.swift
Show resolved
Hide resolved
...SCognitoAuthPluginUnitTests/TaskTests/ClientBehaviorTests/MFA/VerifyTOTPSetupTaskTests.swift
Show resolved
Hide resolved
...luginUnitTests/TaskTests/ClientBehaviorTests/SignIn/ConfirmSignInWithSetUpMFATaskTests.swift
Show resolved
Hide resolved
...luginUnitTests/TaskTests/ClientBehaviorTests/SignIn/ConfirmSignInWithSetUpMFATaskTests.swift
Show resolved
Hide resolved
...nUnitTests/TaskTests/ClientBehaviorTests/SignIn/ConfirmSignInWithMFASelectionTaskTests.swift
Show resolved
Hide resolved
...nUnitTests/TaskTests/ClientBehaviorTests/SignIn/ConfirmSignInWithMFASelectionTaskTests.swift
Show resolved
Hide resolved
...nUnitTests/TaskTests/ClientBehaviorTests/SignIn/ConfirmSignInWithMFASelectionTaskTests.swift
Show resolved
Hide resolved
...nUnitTests/TaskTests/ClientBehaviorTests/SignIn/ConfirmSignInWithMFASelectionTaskTests.swift
Show resolved
Hide resolved
...itoAuthPluginUnitTests/TaskTests/ClientBehaviorTests/SignIn/ConfirmSignInTOTPTaskTests.swift
Show resolved
Hide resolved
|
@thisisabhash I will try to resolve these comments in a future PR. |
9 tasks
harsh62
added a commit
that referenced
this pull request
Jul 4, 2023
* feat(Auth): Adding TOTP support in Amplify Auth category * feat(Auth): Adding TOTP related models to AWSCognitoPlugin * feat(Auth): Adding TOTP service behaviour * feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * feat(Auth): Adding TOTP states, events, data models and resolvers * feat(Auth): Add unit tests for TOTP * feat(Auth): TOTP Unit test changes
9 tasks
harsh62
added a commit
that referenced
this pull request
Jul 19, 2023
* feat(Auth): Adding TOTP support in Amplify Auth category * feat(Auth): Adding TOTP related models to AWSCognitoPlugin * feat(Auth): Adding TOTP service behaviour * feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * feat(Auth): Adding TOTP states, events, data models and resolvers * feat(Auth): Add unit tests for TOTP * feat(Auth): TOTP Unit test changes
harsh62
added a commit
that referenced
this pull request
Jul 25, 2023
* feat(Auth): Adding TOTP support in Amplify Auth category * feat(Auth): Adding TOTP related models to AWSCognitoPlugin * feat(Auth): Adding TOTP service behaviour * feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * feat(Auth): Adding TOTP states, events, data models and resolvers * feat(Auth): Add unit tests for TOTP * feat(Auth): TOTP Unit test changes
harsh62
added a commit
that referenced
this pull request
Aug 1, 2023
* feat(Auth): Adding TOTP support in Amplify Auth category * feat(Auth): Adding TOTP related models to AWSCognitoPlugin * feat(Auth): Adding TOTP service behaviour * feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * feat(Auth): Adding TOTP states, events, data models and resolvers * feat(Auth): Add unit tests for TOTP * feat(Auth): TOTP Unit test changes
harsh62
added a commit
that referenced
this pull request
Aug 28, 2023
* feat(Auth): Adding TOTP support in Amplify Auth category * feat(Auth): Adding TOTP related models to AWSCognitoPlugin * feat(Auth): Adding TOTP service behaviour * feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * feat(Auth): Adding TOTP states, events, data models and resolvers * feat(Auth): Add unit tests for TOTP * feat(Auth): TOTP Unit test changes
harsh62
added a commit
that referenced
this pull request
Aug 28, 2023
* feat(Auth): Adding TOTP support in Amplify Auth category * feat(Auth): Adding TOTP related models to AWSCognitoPlugin * feat(Auth): Adding TOTP service behaviour * feat(Auth): Adding TOTP tasks and requests to AWSAuthCognitoPlugin * feat(Auth): Adding TOTP state machine actions * feat(Auth): Adding TOTP states, events, data models and resolvers * feat(Auth): Add unit tests for TOTP * feat(Auth): TOTP Unit test changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TOTP PR Number # 7
Depends on:
Changes
NOTE: The unit and integration tests will fail until all changes make it to the feature branch
(The PR is directed towards a feature branch)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.