Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updating SQLite.swift to 0.15.3 #3655

Merged
merged 22 commits into from
May 17, 2024
Merged

Conversation

atierian
Copy link
Member

@atierian atierian commented Apr 29, 2024

Issue #

Description

This PR bumps the SQLite.swift dependency from 0.15.0 to 0.15.3.

Other changes:

  • Bumped swift-tools-version from 5.7 to 5.9 in accordance with App Store requirements that went into effect on April 29:

    Apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10 starting April 29, 2024.

  • Updated all the GitHub workflows to run on the arm-based macos-latest runner, and to use the proper Xcode versions.
  • Updated all watch integration test schemes to successfully build and run with Xcode 15
  • Fixed the Push Notification integration tests to work with Xcode 15
  • There seem to be a known issue in Xcode 15+ with NaturalLanguage not really working on simulators, so I've removed the CoreMLPredictionsPlugin unit tests from the workflows.

General Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian temporarily deployed to IntegrationTest April 30, 2024 00:09 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest May 2, 2024 17:30 — with GitHub Actions Inactive
@ruisebas ruisebas changed the title feat: update sqlite.swift dependency to 0.15.3 feat: Updating SQLite.swift to 0.15.3 May 2, 2024
@ruisebas ruisebas marked this pull request as ready for review May 2, 2024 17:42
@ruisebas ruisebas requested a review from a team as a code owner May 2, 2024 17:42
@phantumcode phantumcode requested a review from a team as a code owner May 17, 2024 18:41
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.59%. Comparing base (4156bfb) to head (f5a98e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3655      +/-   ##
==========================================
+ Coverage   68.56%   68.59%   +0.02%     
==========================================
  Files        1096     1089       -7     
  Lines       38119    37653     -466     
==========================================
- Hits        26138    25827     -311     
+ Misses      11981    11826     -155     
Flag Coverage Δ
API_plugin_unit_test 68.97% <ø> (ø)
AWSPluginsCore 65.81% <ø> (ø)
Amplify 48.19% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.32% <ø> (-0.18%) ⬇️
CoreMLPredictions_plugin_unit_test ?
DataStore_plugin_unit_test 82.39% <ø> (-0.03%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (-1.50%) ⬇️
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ukhan-amazon ukhan-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atierian atierian merged commit 5798204 into main May 17, 2024
79 checks passed
@atierian atierian deleted the chore.sqlite-version-update branch May 17, 2024 19:29
@ruisebas ruisebas mentioned this pull request Oct 21, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants