feat: adding vision os preview #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
GitHub Actions
Inactive
harsh62
force-pushed
the
visionos-preview-rebased
branch
from
60c5e48 to
b4e939d
Compare
ruisebas
reviewed
Oct 21, 2024
| @@ -91,21 +94,6 @@ class AWSPinpointAnalyticsPluginIntergrationTests: XCTestCase { | |||
| try await endpointClient.updateEndpointProfile(with: currentProfile) | |||
| } | |||
|
|
|||
| /// Run this test when the number of endpoints for the userId exceeds the limit. | |||
There was a problem hiding this comment.
Let's add this back to save our future selves some head scratching :P
There was a problem hiding this comment.
This is for some reason actually failing the build for the target on the runner. Thats why I removed it.
There was a problem hiding this comment.
Added it back commented with a TODO.
There was a problem hiding this comment.
That is indeed very weird, since this is not really a test but just a method 🤷♂️
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Actions/SignOut/ShowHostedUISignOut.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Actions/SignOut/ShowHostedUISignOut.swift
Outdated
Show resolved
Hide resolved
...fyPlugins/Auth/Sources/AWSCognitoAuthPlugin/StateMachine/CodeGen/Data/SignOutEventData.swift
Outdated
Show resolved
Hide resolved
...sts/AWSDataStorePluginTests/Sync/MutationQueue/MutationIngesterConflictResolutionTests.swift
Outdated
Show resolved
Hide resolved
| @@ -53,6 +53,11 @@ class CoreMLNaturalLanguageAdapterTests: XCTestCase { | |||
| /// - I should get back correct tokens | |||
| /// | |||
| func testSyntaxToken() { | |||
| #if !os(visionOS) | |||
| // TODO: Test failing on visionOS. | |||
There was a problem hiding this comment.
IIRC the CoreML tests are failing in all platforms, that's why they are not being run by the unit tests workflow. See #3655
There was a problem hiding this comment.
Should we fix the tests or keep the TODO for future?
There was a problem hiding this comment.
We couldn't really fix the tests because it was Xcode 15 on simulators that was broken.
If the same issue remains in Xcode 16, I think we're on the same situation as before.
Co-authored-by: Sebastian Villena <[email protected]>
…lify-ios into visionos-preview-rebased
ruisebas
previously approved these changes
Oct 21, 2024
harsh62
changed the title
ruisebas
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Rebased
visionos-previewbranch withmain.Based on customer feedback, we have decided to pushvisionos-previewonmain.Please note that VisionOS support is still in preview, we are just making this merge to make it more accessible to customers by pushing it into our release pipelines. This way customers using Amplify on VisionOS would get other updates that are made on
main.Description
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.