feat: bump min deployment target to 12, include starscream 4.0.6 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d
previously approved these changes
Mar 11, 2024
lawmicha
changed the title
sebaland
requested changes
Mar 19, 2024
|
As a similar PR #159 is merged to main, should we close this ticket? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Starscream's 4.0.6 dependency has min iOS 11
https://github.com/daltoniam/Starscream/blob/4.0.6/Starscream.podspec
We'll bump from min iOS 9 to at least 11. We decided on 12 to align across the repos.
Amplify V1 is also iOS 11 https://github.com/aws-amplify/amplify-swift/blob/6d192e4f3a6ae3855abb479aba090a36e083ce83/AmplifyPlugins.podspec#L28C3-L28C28
We'll bump Amplify V1 to 12 as well.
Amplify V2 is iOS 13 +
AppSyncSDK is iOS 9 https://github.com/awslabs/aws-mobile-appsync-sdk-ios/blob/main/AWSAppSync.podspec#L11
We'll bump this to iOS 12 as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.