feat: upgrade to min deployment version to iOS 12 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d
previously approved these changes
Mar 11, 2024
lawmicha
changed the title
sebaland
reviewed
Apr 23, 2024
.gitignore
Outdated
| @@ -7,3 +7,4 @@ Carthage | |||
| Pods | |||
| .build/ | |||
| build/ | |||
| Pods/ | |||
There was a problem hiding this comment.
Isn't this included with the Pods in line 7? 🤷♂️
There was a problem hiding this comment.
oh, this is due to a auto merge with main. I will remove this line
| @@ -2387,7 +2387,7 @@ | |||
| CODE_SIGN_STYLE = Automatic; | |||
| GCC_C_LANGUAGE_STANDARD = gnu11; | |||
| INFOPLIST_FILE = AWSAppSyncTestAppUITests/Info.plist; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 12.1; | |||
There was a problem hiding this comment.
You've downgraded some targets from 12.1 to 12.0.
Just to be sure, did you validate that these changes are safe?
There was a problem hiding this comment.
Here the AWSAppSyncTestAppUITests is an empty test project. I've verified all the other downgraded targets are success to build.
sebaland
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.