Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IoT): Fixing identity not being created #5189

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix(IoT): Fixing identity not being created #5189

merged 1 commit into from
Feb 7, 2024

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented Feb 7, 2024

Description of changes:

This PR fixes an issue introduced in #5185, in which an SecIdentityRef could not be created due to the private key and/or certificate not being previously added to the Keychain.

The integration tests are now passing: run

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners February 7, 2024 22:18
@sebaland sebaland merged commit 9046c29 into main Feb 7, 2024
65 of 66 checks passed
@sebaland sebaland deleted the fix/iot_manager_fix branch February 7, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisabhash thisisabhash thisisabhash approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebaland @thisisabhash