Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AWSIoT): Fixing crash in AWSIoTMQTTClient #5185

Merged
merged 18 commits into from
Feb 7, 2024
Merged

fix(AWSIoT): Fixing crash in AWSIoTMQTTClient #5185

merged 18 commits into from
Feb 7, 2024

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Feb 5, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
This PR mainly attempts to address a crash in AWSIoTMQTTClient when a connection is active by:

  • Extracting the openStreams method into a separate AWSIoTStreamThread class, to prevent potential out of date references after disconnecting.
  • Replacing key ivars with properties.
  • Adding weakSelf references when dispatching to the global queue.
  • Invalidating all timers on dealloc

Probably not related to the crash itself, but this PR also fixes several CoreFoundation memory leaks caused by objects not being properly released after creation.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas merged commit e209fa3 into main Feb 7, 2024
66 checks passed
@ruisebas ruisebas deleted the fix/iot_crashes branch February 7, 2024 19:15
@ruisebas ruisebas mentioned this pull request Feb 7, 2024
Merged
6 tasks
This was referenced Feb 9, 2024
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
@ruisebas ruisebas mentioned this pull request Feb 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisabhash thisisabhash thisisabhash approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruisebas @thisisabhash @5d