-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IoT): Fixing auto reconnection not working properly. #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
February 16, 2024 19:46 — with
GitHub Actions
Inactive
harsh62
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thisisabhash
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR addresses an issue introduced in the refactor made on #5185.
When a reconnection happens, neither the session nor the streams are recreated (i.e. the existing ones are reused), so the
AWSIoTStreamThread
should not close them when it gets cancelled because of a reconnection.I've solved this issue by creating a new
cancelAndDisconnect:
method that can be invoked with the proper flag when creating a new thread, i.e.self.userDidIssueDisconnect
. A reconnection then would keep all the streams open and continue to receive updates.Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.