feat(AWSCore): Upgrading CocoaLumberjack to version 3.8.4 #5222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR upgrades the CocoaLumberjack fork within
AWSCore
(calledAWSCocoaLumberjack
) to version 3.8.4.I've also updated the README to use
AWSDDOSLogger
instead ofAWSDDTTYLogger
in our logging example.Additional Changes
The following has been made for backwards compatibility:
logLevel
property inAWSDDLog
, so that customers can easily set the global log level.AWSDDTTYLogger.sharedInstance
is explicitly marked asnullable
, but theid<AWSLogger>
arguments in[AWSDDLog add:]
and[AWSDDLog add:withLevel:]
have been explicitly marked asnon-null
. This is technically a breaking change for Swift customers, so I've added a Swift extension that offers methods that take optionals, but are deprecated and instruct to not use optionalsAWSDDTTYLogger.sharedInstance
could still returnnil
and then it would just be ignored by[AWSDDLog add:]
and[AWSDDLog add:withLevel:]
.Check points:
Added new tests to cover change, if neededDocumentation update for the change if requiredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.