Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWSCore): Upgrading CocoaLumberjack to version 3.8.4 #5222

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented Feb 29, 2024

Description of changes

This PR upgrades the CocoaLumberjack fork within AWSCore (called AWSCocoaLumberjack) to version 3.8.4.

I've also updated the README to use AWSDDOSLogger instead of AWSDDTTYLogger in our logging example.

Additional Changes

The following has been made for backwards compatibility:

  • Addition of the logLevel property in AWSDDLog, so that customers can easily set the global log level.
  • AWSDDTTYLogger.sharedInstance is explicitly marked as nullable, but the id<AWSLogger> arguments in [AWSDDLog add:] and [AWSDDLog add:withLevel:] have been explicitly marked as non-null. This is technically a breaking change for Swift customers, so I've added a Swift extension that offers methods that take optionals, but are deprecated and instruct to not use optionals
    • ⚠️ Note: The actual behaviour has not changed. In the old version, AWSDDTTYLogger.sharedInstance could still return nil and then it would just be ignored by [AWSDDLog add:] and [AWSDDLog add:withLevel:].

Check points:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland marked this pull request as ready for review February 29, 2024 22:07
@sebaland sebaland requested review from awsmobilesdk and a team as code owners February 29, 2024 22:07
@sebaland sebaland force-pushed the feat/target_version branch from 39b318d to 7515921 Compare April 9, 2024 18:10
@sebaland sebaland force-pushed the ruisebas/cocoalumberjack-upgrade branch from 04162c4 to 6af2270 Compare April 9, 2024 18:12
@sebaland sebaland force-pushed the feat/target_version branch from 7515921 to eb9470a Compare April 16, 2024 19:29
@sebaland sebaland changed the title feat(AWSCore): Upgrading CocoaLumberjack to version 3.4.8 feat(AWSCore): Upgrading CocoaLumberjack to version 3.8.4 Apr 16, 2024
@sebaland sebaland force-pushed the ruisebas/cocoalumberjack-upgrade branch from 6af2270 to f0b6316 Compare April 16, 2024 20:05
@sebaland sebaland merged commit fd933ff into feat/target_version Apr 18, 2024
@sebaland sebaland deleted the ruisebas/cocoalumberjack-upgrade branch April 18, 2024 19:34
sebaland added a commit that referenced this pull request Apr 18, 2024
* feat(AWSCore): Upgrading CocoaLumberjack to version 3.8.4 (#5222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants