Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade iOS deployment target to iOS 12 #5223

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented Mar 1, 2024

Description of changes:
This PR updates the iOS deployment target version to iOS 12 to all the pods that had it at iOS 9.

Xcode 15's minimum deployment target is iOS 9, so attempting to use any of the products resulted in a warning

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 12.0 to 17.2.99.

Bumping the version also reveals a couple of deprecation warnings, so I've fixed the ones that were simple fixes (e.g. SFAuthenticationSession -> ASWebAuthenticationSession).

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:03 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:03 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:03 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:04 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:29 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:29 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:29 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:29 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest March 1, 2024 19:29 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 20:40 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 20:40 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 18, 2024 21:05 — with GitHub Actions Inactive
@sebaland sebaland merged commit 2d643a5 into main Apr 18, 2024
67 checks passed
@sebaland sebaland deleted the feat/target_version branch April 18, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants