Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWSMobileClient): Fixing HostedUI not showed when using navigationController #5324

Merged
merged 1 commit into from
May 6, 2024

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented May 6, 2024

Issue #, if available:

Description of changes:
Attempting to present the HostedUI with a navigationController always failed because no presentationAnchor is set.

I'm bringing back SFAuthenticationSession to solve this issue by reverting the changes made in #5223., as this workflow is meant to be a "legacy" one and not based on ASWebAuthenticationSession.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners May 6, 2024 15:52
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 15:56 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 6, 2024 16:25 — with GitHub Actions Inactive
@sebaland sebaland merged commit 09d0771 into main May 6, 2024
67 checks passed
@sebaland sebaland deleted the ruisebas/fix_hosted_ui branch May 6, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants