Use "go 1.18" in go.mod files #3456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have reasons to use "go 1.12". The agent itself and the dependencies wouldn't work with the version. Go 1.18 is picked since it is the latest Go version in Amazon Linux 2. https://go.dev/ref/mod#go-mod-file Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
go-version-in-mod
branch
from
301bfc8 to
4dd65be
Compare
kzys
force-pushed
the
go-version-in-mod
branch
3 times, most recently
from
04fd7f4 to
612bf98
Compare
Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
go-version-in-mod
branch
from
612bf98 to
cacb089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have reasons to use "go 1.12". The agent itself and the dependencies wouldn't work with the version.
Go 1.18 is picked since it is the latest Go version in Amazon Linux 2.
https://go.dev/ref/mod#go-mod-file
Signed-off-by: Kazuyoshi Kato [email protected]
Summary
Use
go 1.18in go.mod files.Implementation details
go 1.18in go.mod filesTesting
New tests cover the changes: no
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.