Upgrade github.com/golang/mock and mockgen from 1.3.x to 1.6.0 #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
force-pushed
the
mockgen
branch
8 times, most recently
from
582dc6c to
abe0dbb
Compare
kzys
changed the title
kzys
force-pushed
the
mockgen
branch
4 times, most recently
from
5bfcb7b to
e1b0ef6
Compare
We shouldn't ask developers to use mockgen 1.3.x from 2019. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
mockgen
branch
3 times, most recently
from
621a4b1 to
662d8ab
Compare
mockgen 1.6 is more strict than 1.3. Signed-off-by: Kazuyoshi Kato <[email protected]>
sparrc
approved these changes
Mar 16, 2023
Closed
ubhattacharjya
approved these changes
Mar 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kazuyoshi Kato [email protected]
Summary
Upgrade github.com/golang/mock and mockgen from 1.3.x to 1.6.0.
Implementation details
The first commit upgrades github.com/golang/mock and mockgen. The second commit fixes test failures due to the upgrade.
Testing
New tests cover the changes: no
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.