Internal Managed Daemon Definition #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mye956
reviewed
Jun 20, 2023
mye956
reviewed
Jun 20, 2023
mye956
reviewed
Jun 20, 2023
mye956
approved these changes
Jun 20, 2023
prateekchaudhry
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the (internal-only) ManagedDaemon definition to the common library and update common lib vendor.
Implementation details
The ManagedDaemon object encapsulates the core set of daemon definition parameters. These will be used by the ECS Agent to start agent-only daemon processes to be used by the ECS Agent to extend its own capabilities.
This current change includes the ManagedDaemon definition with a subset of getters/setters based on requirements.
Creation of a complete ManagedDaemon object will often require subsequent calls to set the Daemon Environment and the Daemon MountPoints -- each of these has its own specific get/set logic.
The Daemon has a generic Health Check definition with a runtime-specific method to export as a Docker HealthConfig.
Testing
Validated locally with new unit tests included.
New tests cover the changes: yes
Description for the changelog
Add the ManagedDaemon definition to the common library.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.