Downgrade ecs-agent dependency versions to match agent #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Downgrading the versions of the following two ecs-agent dependencies to match agent module versions.
github.com/docker/dockerdowngraded fromv24.0.2tov20.10.24.github.com/docker/go-unitsdowngraded fromv0.5.0tov0.4.0.ecs-agent became dependent on these modules in #3754. I confirmed with the author of that PR that we don't need the latest versions of the above dependencies and that the versions used by agent module are fine. Without this change
go mod tidyon agent module bumps the versions of these dependencies for agent module which we don't have a need for at the moment and would require additional qualification testing.Rest of the changes in this PR are a result of
go mod tidy && go mod vendor.Implementation details
go mod tidy && go mod vendorin ecs-agent module.go mod tidy && go mod vendorin agent module.Testing
New tests cover the changes: NA
Description for the changelog
Downgrade ecs-agent dependency versions to match agent
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.