Use the same docker version in /agent and /ecs-agent #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a conflict in the versions of |
ohsoo
force-pushed
the
unify-docker-version
branch
from
112bdba to
8774625
Compare
ohsoo
force-pushed
the
unify-docker-version
branch
from
8774625 to
8e221c3
Compare
amogh09
approved these changes
Jun 27, 2023
Realmonia
approved these changes
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Downgrade the docker/docker version in the /ecs-agent/go.mod to the same version used in the /agent/go.mod
Implementation details
Manually updated the version and ran
go mod tidyandgo mod vendor.Testing
Existing tests ran
New tests cover the changes: no
Description for the changelog
Downgrade the docker version used in the ecs-agent/go.mod to v20.10.24
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.