Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/awsutils: Update not to render sensitive fields for StringValue #2310

Merged
merged 3 commits into from
Dec 4, 2018
Merged

aws/awsutils: Update not to render sensitive fields for StringValue #2310

merged 3 commits into from
Dec 4, 2018

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Nov 28, 2018 •
edited
Loading

Updates the StringValue utility to not render fields decorated with
sensitive fields. Instead, sensitive fields are outputted as
<sensitive>. This change is limited to the output of StringValue
utility method.

@jasdel jasdel self-assigned this Nov 28, 2018
@jasdel jasdel force-pushed the feat/SuppressSensitiveLogging branch 2 times, most recently from 9ce8af2 to aade050 Compare November 28, 2018 18:53
jasdel added 2 commits December 3, 2018 09:56
@jasdel
aws/awsutils: Update not to render sensitive fields for StringValue
3b769e8 
Updates the StringValue utility to not render fields decorated with
sensitive fields. Instead, sensitive fields are outputted as
"<sensitive>". This change is limited to the output of StringValue
utility method.
@jasdel
regenerate services
fe851bf
@jasdel jasdel force-pushed the feat/SuppressSensitiveLogging branch from aade050 to fe851bf Compare December 3, 2018 18:03
@jasdel jasdel merged commit 1cc199f into aws:master Dec 4, 2018
@jasdel jasdel deleted the feat/SuppressSensitiveLogging branch December 4, 2018 22:28
jasdel added a commit that referenced this pull request Dec 4, 2018
@jasdel
Adds PR to pending change log
6c07f02 
Adds merged PRs,  #2310, #2308, and #2323 to pending change log.
@aws-sdk-go-automation aws-sdk-go-automation mentioned this pull request Dec 5, 2018
Merged
@jasdel jasdel mentioned this pull request Dec 14, 2018
Closed
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this pull request Sep 20, 2019
@jasdel
internal/awsutil: Add suppressing logging sensitive API parameters
98f9492 
Adds suppressing logging sensitive API parameters marked with the
`sensitive` trait. This prevents the API type's `String` method
returning a string representation of the API type with sensitive fields
printed such as keys and passwords.

Related to aws/aws-sdk-go#2310
Fixes aws#251
@jasdel jasdel mentioned this pull request Sep 20, 2019
Merged
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this pull request Sep 20, 2019
@jasdel
internal/awsutil: Add suppressing logging sensitive API parameters
aed2052 
Adds suppressing logging sensitive API parameters marked with the
`sensitive` trait. This prevents the API type's `String` method
returning a string representation of the API type with sensitive fields
printed such as keys and passwords.

Related to aws/aws-sdk-go#2310
Fixes aws#251
jasdel added a commit to aws/aws-sdk-go-v2 that referenced this pull request Sep 23, 2019
@jasdel
internal/awsutil: Add suppressing logging sensitive API parameters (#398
57d74d6 
)

Adds suppressing logging sensitive API parameters marked with the
`sensitive` trait. This prevents the API type's `String` method
returning a string representation of the API type with sensitive fields
printed such as keys and passwords.

Related to aws/aws-sdk-go#2310
Fixes #251
skmcgrail added a commit to skmcgrail/aws-sdk-go-v2 that referenced this pull request Oct 1, 2019
@skmcgrail
Release v0.13.0 (2019-10-01)
c711779 
* Synced the V2 SDK with latest AWS service API definitions.

* This update includes breaking changes to how the DynamoDB AttributeValue (un)marshier handles empty collections.

* `service/s3/s3crypto`: Deprecates the crypto client from the SDK ([aws#394](aws#394))
  * s3crypto client is now deprecated and may be removed from the future versions of the SDK.
* `aws`: Removes plugin credential provider ([aws#391](aws#391))
  * Removing plugin credential provider from the v2 SDK developer preview. This feature may be made available as a separate module.
* Removes support for deprecated Go versions ([aws#393](aws#393))
  * Removes support for Go version specific files from the SDK. Also removes irrelevant build tags, and updates the README.md file.
  * Raises the minimum supported version to Go 1.11 for the SDK. Older versions may work, but are not actively supported

* `service/s3/s3manager`: Add Upload Buffer Provider ([aws#404](aws#404))
  * Adds a new `BufferProvider` member for specifying how part data can be buffered in memory.
  * Windows platforms will now default to buffering 1MB per part to reduce contention when uploading files.
  * Non-Windows platforms will continue to employ a non-buffering behavior.
* `service/s3/s3manager`: Add Download Buffer Provider ([aws#404](aws#404))
  * Adds a new `BufferProvider` member for specifying how part data can be buffered in memory when copying from the http response body.
  * Windows platforms will now default to buffering 1MB per part to reduce contention when downloading files.
  * Non-Windows platforms will continue to employ a non-buffering behavior.
* `service/dynamodb/dynamodbattribute`: New Encoder and Decoder Behavior for Empty Collections ([aws#401](aws#401))
  * The `Encoder` and `Decoder` types have been enhanced to support the marshaling of empty structures, maps, and slices to and from their respective DynamoDB AttributeValues.
  * This change incorporates the behavior changes introduced via a marshal option in V1 ([aws#2834](aws/aws-sdk-go#2834))

* `internal/awsutil`: Add suppressing logging sensitive API parameters ([aws#398](aws#398))
  * Adds suppressing logging sensitive API parameters marked with the `sensitive` trait. This prevents the API type's `String` method returning a string representation of the API type with sensitive fields printed such as keys and passwords.
  * Related to [aws/aws-sdk-go#2310](aws/aws-sdk-go#2310)
  * Fixes [aws#251](aws#251)
* `aws/request` : Retryer is now a named field on Request. ([aws#393](aws#393))
* `service/s3/s3manager`: Adds `sync.Pool` to allow reuse of part buffers for streaming payloads ([aws#404](aws#404))
  * Fixes [aws#402](aws#402)
  * Uses the new behavior introduced in V1 [aws#2863](aws/aws-sdk-go#2863) which allows the reuse of the sync.Pool across multiple Upload request that match part sizes.

* `service/s3/s3manager`: Fix index out of range when a streaming reader returns -1 ([aws#378](aws#378))
  * Fixes the S3 Upload Manager's handling of an unbounded streaming reader that returns negative bytes read.
* `internal/ini`: Fix ini parser to handle empty values [aws#406](aws#406)
  * Fixes incorrect modifications to the previous token value of the skipper. Adds checks for cases where a skipped statement should be marked as complete and not be ignored.
  * Adds tests for nested and empty field value parsing, along with tests suggested in [aws/aws-sdk-go#2801](aws/aws-sdk-go#2801)
@skmcgrail skmcgrail mentioned this pull request Oct 1, 2019
Merged
skmcgrail added a commit to skmcgrail/aws-sdk-go-v2 that referenced this pull request Oct 1, 2019
@skmcgrail
Release v0.13.0 (2019-10-01) (aws#409)
6774789 
### Services
* Synced the V2 SDK with latest AWS service API definitions.

### SDK Breaking changes
* This update includes breaking changes to how the DynamoDB AttributeValue (un)marshier handles empty collections.

### Deprecations
* `service/s3/s3crypto`: Deprecates the crypto client from the SDK ([aws#394](aws#394))
  * s3crypto client is now deprecated and may be removed from the future versions of the SDK.
* `aws`: Removes plugin credential provider ([aws#391](aws#391))
  * Removing plugin credential provider from the v2 SDK developer preview. This feature may be made available as a separate module.
* Removes support for deprecated Go versions ([aws#393](aws#393))
  * Removes support for Go version specific files from the SDK. Also removes irrelevant build tags, and updates the README.md file.
  * Raises the minimum supported version to Go 1.11 for the SDK. Older versions may work, but are not actively supported

### SDK Features
* `service/s3/s3manager`: Add Upload Buffer Provider ([aws#404](aws#404))
  * Adds a new `BufferProvider` member for specifying how part data can be buffered in memory.
  * Windows platforms will now default to buffering 1MB per part to reduce contention when uploading files.
  * Non-Windows platforms will continue to employ a non-buffering behavior.
* `service/s3/s3manager`: Add Download Buffer Provider ([aws#404](aws#404))
  * Adds a new `BufferProvider` member for specifying how part data can be buffered in memory when copying from the http response body.
  * Windows platforms will now default to buffering 1MB per part to reduce contention when downloading files.
  * Non-Windows platforms will continue to employ a non-buffering behavior.
* `service/dynamodb/dynamodbattribute`: New Encoder and Decoder Behavior for Empty Collections ([aws#401](aws#401))
  * The `Encoder` and `Decoder` types have been enhanced to support the marshaling of empty structures, maps, and slices to and from their respective DynamoDB AttributeValues.
  * This change incorporates the behavior changes introduced via a marshal option in V1 ([aws#2834](aws/aws-sdk-go#2834))

### SDK Enhancements
* `internal/awsutil`: Add suppressing logging sensitive API parameters ([aws#398](aws#398))
  * Adds suppressing logging sensitive API parameters marked with the `sensitive` trait. This prevents the API type's `String` method returning a string representation of the API type with sensitive fields printed such as keys and passwords.
  * Related to [aws/aws-sdk-go#2310](aws/aws-sdk-go#2310)
  * Fixes [aws#251](aws#251)
* `aws/request` : Retryer is now a named field on Request. ([aws#393](aws#393))
* `service/s3/s3manager`: Adds `sync.Pool` to allow reuse of part buffers for streaming payloads ([aws#404](aws#404))
  * Fixes [aws#402](aws#402)
  * Uses the new behavior introduced in V1 [aws#2863](aws/aws-sdk-go#2863) which allows the reuse of the sync.Pool across multiple Upload request that match part sizes.

### SDK Bugs
* `service/s3/s3manager`: Fix index out of range when a streaming reader returns -1 ([aws#378](aws#378))
  * Fixes the S3 Upload Manager's handling of an unbounded streaming reader that returns negative bytes read.
* `internal/ini`: Fix ini parser to handle empty values [aws#406](aws#406)
  * Fixes incorrect modifications to the previous token value of the skipper. Adds checks for cases where a skipped statement should be marked as complete and not be ignored.
  * Adds tests for nested and empty field value parsing, along with tests suggested in [aws/aws-sdk-go#2801](aws/aws-sdk-go#2801)
skmcgrail added a commit to aws/aws-sdk-go-v2 that referenced this pull request Oct 2, 2019
@skmcgrail
Release v0.13.0 (2019-10-01) (#409)
002fb7d 
### Services
* Synced the V2 SDK with latest AWS service API definitions.

### SDK Breaking changes
* This update includes breaking changes to how the DynamoDB AttributeValue (un)marshier handles empty collections.

### Deprecations
* `service/s3/s3crypto`: Deprecates the crypto client from the SDK ([#394](#394))
  * s3crypto client is now deprecated and may be removed from the future versions of the SDK.
* `aws`: Removes plugin credential provider ([#391](#391))
  * Removing plugin credential provider from the v2 SDK developer preview. This feature may be made available as a separate module.
* Removes support for deprecated Go versions ([#393](#393))
  * Removes support for Go version specific files from the SDK. Also removes irrelevant build tags, and updates the README.md file.
  * Raises the minimum supported version to Go 1.11 for the SDK. Older versions may work, but are not actively supported

### SDK Features
* `service/s3/s3manager`: Add Upload Buffer Provider ([#404](#404))
  * Adds a new `BufferProvider` member for specifying how part data can be buffered in memory.
  * Windows platforms will now default to buffering 1MB per part to reduce contention when uploading files.
  * Non-Windows platforms will continue to employ a non-buffering behavior.
* `service/s3/s3manager`: Add Download Buffer Provider ([#404](#404))
  * Adds a new `BufferProvider` member for specifying how part data can be buffered in memory when copying from the http response body.
  * Windows platforms will now default to buffering 1MB per part to reduce contention when downloading files.
  * Non-Windows platforms will continue to employ a non-buffering behavior.
* `service/dynamodb/dynamodbattribute`: New Encoder and Decoder Behavior for Empty Collections ([#401](#401))
  * The `Encoder` and `Decoder` types have been enhanced to support the marshaling of empty structures, maps, and slices to and from their respective DynamoDB AttributeValues.
  * This change incorporates the behavior changes introduced via a marshal option in V1 ([#2834](aws/aws-sdk-go#2834))

### SDK Enhancements
* `internal/awsutil`: Add suppressing logging sensitive API parameters ([#398](#398))
  * Adds suppressing logging sensitive API parameters marked with the `sensitive` trait. This prevents the API type's `String` method returning a string representation of the API type with sensitive fields printed such as keys and passwords.
  * Related to [aws/aws-sdk-go#2310](aws/aws-sdk-go#2310)
  * Fixes [#251](#251)
* `aws/request` : Retryer is now a named field on Request. ([#393](#393))
* `service/s3/s3manager`: Adds `sync.Pool` to allow reuse of part buffers for streaming payloads ([#404](#404))
  * Fixes [#402](#402)
  * Uses the new behavior introduced in V1 [#2863](aws/aws-sdk-go#2863) which allows the reuse of the sync.Pool across multiple Upload request that match part sizes.

### SDK Bugs
* `service/s3/s3manager`: Fix index out of range when a streaming reader returns -1 ([#378](#378))
  * Fixes the S3 Upload Manager's handling of an unbounded streaming reader that returns negative bytes read.
* `internal/ini`: Fix ini parser to handle empty values [#406](#406)
  * Fixes incorrect modifications to the previous token value of the skipper. Adds checks for cases where a skipped statement should be marked as complete and not be ignored.
  * Adds tests for nested and empty field value parsing, along with tests suggested in [aws/aws-sdk-go#2801](aws/aws-sdk-go#2801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jasdel jasdel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jasdel