internal/ini: Failing test cases for #2800

[bflad]

Reference: #2800

My apologies I won't have time to dive into the INI parsing code for awhile to fully resolve this. It appears anything between the first new line token and next new line token when in the skip state is completely skipped, even if it contains a separator.

--- FAIL: TestParser (0.00s)
    --- FAIL: TestParser/complex_section_statement#02 (0.00s)
        ini_parser_test.go:302: expected same length 4, but received 3
        ini_parser_test.go:317: expected:
            	0: {completed_stmt {0 NONE 0 []} false [{section_stmt {1 STRING 0 [100 101 102 97 117 108 116]} true []}]}
            	1: {skip {0 NONE 0 []} false [{ {4 NONE 0 [61]} true [{expr {1 STRING 0 [115 51]} true []}]}]}
            	2: {completed_stmt {0 NONE 0 []} false [{section_stmt {1 STRING 0 [97 115 115 117 109 101 114 111 108 101]} true []}]}
            	3: {expr_stmt {0 NONE 0 []} false [{ {4 NONE 0 [61]} true [{expr {1 STRING 0 [111 117 116 112 117 116]} true []} {expr {1 STRING 0 [106 115 111 110]} true []}]}]}

            received:
            	0: {completed_stmt {0 NONE 0 []} false [{section_stmt {1 STRING 0 [100 101 102 97 117 108 116]} true []}]}
            	1: {skip {0 NONE 0 []} false [{ {4 NONE 0 [61]} true [{expr {1 STRING 0 [115 51]} true []}]}]}
            	2: {expr_stmt {0 NONE 0 []} false [{ {4 NONE 0 [61]} true [{expr {1 STRING 0 [111 117 116 112 117 116]} true []} {expr {1 STRING 0 [106 115 111 110]} true []}]}]}
--- FAIL: TestValidDataFiles (0.01s)
    walker_test.go:59: could not find profile bar

[jasdel]

Thanks for reporting this issue, and providing the testcase @bflad. I think this bug is an artifact for the SDK's built in parser handling nested key/value pairs. Though that behavior should handle the case where a field is started but no nested key/value pairs are provided.

I think the SDK's INI parser should terminate its parsing of nested block when the next line starts with no whitespace, or is a new section.

Exampled of nested key/value pairs the parser should recognize.

[section]
parentKey = 
    nestedKey = abc

Example of an INI file the parser should also correctly parse where someKey in both first and othersections have empty value, andotherKeyinother` section is also empty.

[first]
someKey =
[second]

[other]
someKey = 
otherKey =

[jasdel]

Closing this as the fixed was released in v1.25.4 PR #2860