-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to min deployment version to iOS 12 #586
Changes from 6 commits
24bf0d7
62c11af
9df1592
5146356
169c91a
e45b3ee
fe8af6e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ Carthage | |
Pods | ||
.build/ | ||
build/ | ||
Pods/ | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2265,7 +2265,7 @@ | |
CODE_SIGN_STYLE = Automatic; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = ApolloTests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 11.2; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2294,7 +2294,7 @@ | |
CODE_SIGN_STYLE = Automatic; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = ApolloTests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 11.2; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2327,7 +2327,7 @@ | |
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = StarWarsAPI/Info.plist; | ||
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2362,7 +2362,7 @@ | |
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = StarWarsAPI/Info.plist; | ||
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2387,7 +2387,7 @@ | |
CODE_SIGN_STYLE = Automatic; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestAppUITests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You've downgraded some targets from 12.1 to 12.0. Just to be sure, did you validate that these changes are safe? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here the |
||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2413,7 +2413,7 @@ | |
CODE_SIGN_STYLE = Automatic; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestAppUITests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2441,7 +2441,7 @@ | |
CODE_SIGN_STYLE = Automatic; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestHostApp/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2468,7 +2468,7 @@ | |
CODE_SIGN_STYLE = Automatic; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestHostApp/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2494,7 +2494,7 @@ | |
DEVELOPMENT_TEAM = W9GWBC2HN3; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestApp/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.3; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2519,7 +2519,7 @@ | |
DEVELOPMENT_TEAM = W9GWBC2HN3; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestApp/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.3; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2661,7 +2661,7 @@ | |
DYLIB_INSTALL_NAME_BASE = "@rpath"; | ||
INFOPLIST_FILE = AWSAppSyncClient/Info.plist; | ||
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2690,7 +2690,7 @@ | |
DYLIB_INSTALL_NAME_BASE = "@rpath"; | ||
INFOPLIST_FILE = AWSAppSyncClient/Info.plist; | ||
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2719,7 +2719,7 @@ | |
DEVELOPMENT_TEAM = ""; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncUnitTests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2748,7 +2748,7 @@ | |
DEVELOPMENT_TEAM = ""; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncUnitTests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2776,7 +2776,7 @@ | |
DEVELOPMENT_TEAM = ""; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncIntegrationTests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2806,7 +2806,7 @@ | |
DEVELOPMENT_TEAM = ""; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncIntegrationTests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.1; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2839,7 +2839,7 @@ | |
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestCommon/Info.plist; | ||
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
@@ -2872,7 +2872,7 @@ | |
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = AWSAppSyncTestCommon/Info.plist; | ||
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
"@executable_path/Frameworks", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this included with the
Pods
in line 7? 🤷♂️There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, this is due to a auto merge with main. I will remove this line