spark updates to 1.5 and also removing setting of default #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 21, 2015 15:56
…Spark cancelling method all made uniform to kill launched hadoop jobs
| @@ -283,8 +283,7 @@ private static void sparkJarsHelper(Props jobProps, String workingDir, | |||
| Logger log, List<String> argList) { | |||
| String jarList = | |||
| HadoopJobUtils.resolveWildCardForJarSpec(workingDir, jobProps | |||
| .getString(SparkJobArg.SPARK_JARS.azPropName, | |||
| SparkJobArg.SPARK_JARS.defaultValue), log); | |||
| .getString(SparkJobArg.SPARK_JARS.azPropName, ""), log); | |||
There was a problem hiding this comment.
Nit: better to have split arguments rather than the . operator (i.e. at a higher syntactic level):
String jarList =
HadoopJobUtils.resolveWildCardForJarSpec(workingDir,
jobProps.getString(SparkJobArg.SPARK_JARS.azPropName, ""), log);See: https://google.github.io/styleguide/javaguide.html#s4.5-line-wrapping
|
LG overall. Can you take a look at the test failure? Thanks! |
added 9 commits
October 13, 2015 12:44
johnyu0520
pushed a commit
to johnyu0520/azkaban-plugins
that referenced
this pull request
Oct 13, 2015
addressed azkaban#204 comments bug fix in SparkJobArgs.java make build completion dependent on passing plugins/jobtype junit test cases
|
please find the squashed pull request at #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will squash commit after review is done