updates to spark job type #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 21, 2015 15:56
…Spark cancelling method all made uniform to kill launched hadoop jobs
addressed azkaban#204 comments bug fix in SparkJobArgs.java make build completion dependent on passing plugins/jobtype junit test cases
|
The diff itself looks good. There are still multiple commits here. Can you squash them into a single commit? Feel free to let me know if you need any help doing the squash. |
|
Hey David, many of those commits are over 2 weeks ago and intertwined with other already merged into master changes. I would rather not touch them... |
|
Understood. That is fine for this PR then. Thanks for taking the time to squash the other commits! |
| @@ -3,61 +3,54 @@ | |||
| public enum SparkJobArg { | |||
|
|
|||
| // standard spark submit arguments, ordered in the spark-submit --help order | |||
| MASTER("master", "yarn-cluster", false), // just to trick the eclipse formatter | |||
| MASTER("master", false), // just to trick the eclipse formatter | |||
There was a problem hiding this comment.
Just curious, what is the motivation for removing the default values?
|
LGTM |
|
@davidzchen |
|
No problem. Thanks, @johnyu0520! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for Spark: removing the code for setting default values …
addressed #204 comments
bug fix in SparkJobArgs.java
make build completion dependent on passing plugins/jobtype junit test cases
This is basically the same code reviewed in #204, with a few recent commits squashed (I won't touch the commits from 3 weeks ago as it would be a lot of conflicts)
https://github.com/azkaban/azkaban-plugins/pull/204/files