Use node.js v20 #51
Use node.js v20 #51
Conversation
package.json
Outdated
| "@octokit/core": "*", | ||
| "@octokit/graphql": "*", | ||
| "@octokit/plugin-paginate-graphql": "*", | ||
| "fetch-mock": "^9.11.0" | ||
| "fetch-mock": "npm:@gr2m/fetch-mock@9.11.0-pull-request-644.1" |
There was a problem hiding this comment.
I have tried to find an alternative for fetch-mock for mocking requests produced by @octokit but ended up following the example of @octokit's mocking for their own tests.
Context (grab some popcorn and make your self comfy): @octokit packages moved to support for node.js 20. Node.js 20 switched from http to defaulting to global fetch function based on undici-fetch.
As a consequence, standard mocking libraries like nock are (still) not supporting this default. Thus when using @ocotokit we had to use fetch-mock as recommended by the owners of @octokit.
Unfortunately, fetch-mock has not been actively maintained for ... two years. Therefore, the @octokit team submitted a PR and is now referencing this for mocking in their own project.
Far from being ideal, I still suggest to follow the lead of @octokit because this is the set of packages we need to mock.
I tried the new built-in node:test mock which has zero convenience and did not work for mocking fetch - at least for me. I also tried nock as mentioned above and looked for up-to date alternatives but nothing seemed to work. Mock Service Worker has recently become popular, but this seems to follow be its own framework and so I did not even test it.
|
It might work with MSW mswjs/msw#1543 ... . |
Co-authored-by: Jan Sebastian Siwy <[email protected]>
... instead of re-creating msw server.
Mock with MSW
Tested in sandbox with https://github.com/babbel-sandbox/test-projects-again/pull/64.