Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock with MSW #52

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Mock with MSW #52

merged 7 commits into from
Nov 29, 2023

Conversation

jtsaito
Copy link
Contributor

@jtsaito jtsaito commented Nov 28, 2023

I've additionally smoke tested the change in babbel-sandbox "just in case" because I named some of the GraphQL operations.

@jtsaito jtsaito self-assigned this Nov 28, 2023
@jtsaito jtsaito marked this pull request as ready for review November 28, 2023 16:38
@jtsaito jtsaito requested a review from a team November 28, 2023 16:38
apiwrapper.js Outdated Show resolved Hide resolved
__tests__/apiwrapper.js Outdated Show resolved Hide resolved
__tests__/apiwrapper.js Outdated Show resolved Hide resolved
@jtsaito
Copy link
Contributor Author

jtsaito commented Nov 29, 2023

@jansiwy Incorporated your suggestions. Also switched to keeping MSW server instance.

@jtsaito jtsaito requested a review from jansiwy November 29, 2023 09:38
@jtsaito jtsaito merged commit 0aa6323 into node.js-v20 Nov 29, 2023
1 check passed
@jtsaito jtsaito deleted the msw branch November 29, 2023 11:18
@jtsaito jtsaito mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants