Breaking: Change peerDep to @babel/core #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
force-pushed
the
peerDep-@babel/core
branch
from
2c02018 to
738b957
Compare
hzoo
commented
Oct 31, 2017
| @@ -80,9 +79,6 @@ | |||
| "text", | |||
| "json" | |||
| ], | |||
| "require": [ | |||
| "babel-register" | |||
There was a problem hiding this comment.
don't need register either for nyc
loganfsmyth
reviewed
Oct 31, 2017
.babelrc
Outdated
| @@ -1,6 +1,11 @@ | |||
| { | |||
| "presets": [ | |||
| ["env", { "loose": true, "targets": { "node": "4.2" } }] | |||
| ["@babel/preset-env", { | |||
There was a problem hiding this comment.
You can leave off the preset- if you want.
Also looks like there are a bunch of things in the README that will need updating.
loganfsmyth
approved these changes
Oct 31, 2017
hzoo
changed the title
This was referenced Feb 25, 2018
This was referenced Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok removed inherits since it's not necessary