[WIP] First pass at mesh shader debugging for SPIR-V & Vulkan #2860
ci.yml
on: pull_request
Baseline cmake check
0s
Documentation Build
0s
Android
0s
Matrix: Linux
Matrix: Mac
Matrix: Windows
Annotations
2 errors
Code formatting check
clang-format issues were found. See CONTRIBUTING.md for more information.
diff --git a/qrenderdoc/Windows/BufferViewer.cpp b/qrenderdoc/Windows/BufferViewer.cpp
index 74ee5a9..e297f5b 100644
--- a/qrenderdoc/Windows/BufferViewer.cpp
+++ b/qrenderdoc/Windows/BufferViewer.cpp
@@ -3128,7 +3128,6 @@ void BufferViewer::stageRowMenu(MeshDataStage stage, QMenu *menu, const QPoint &
}
menu->addAction(m_DebugMeshletVert);
-
menu->addSeparator();
m_GotoTask->setEnabled(m_Ctx.CurPipelineState().GetShaderReflection(ShaderStage::Task));
@@ -6690,8 +6689,9 @@ void BufferViewer::debugMeshletVertex()
if(!idx.isValid())
{
GUIInvoke::call(this, [this]() {
- RDDialog::critical(this, tr("Error debugging"),
- tr("Error debugging meshlet vertex - make sure a valid vertex is selected"));
+ RDDialog::critical(
+ this, tr("Error debugging"),
+ tr("Error debugging meshlet vertex - make sure a valid vertex is selected"));
});
return;
}
diff --git a/renderdoc/api/replay/renderdoc_replay.h b/renderdoc/api/replay/renderdoc_replay.h
index ea97d9a..6e0df1e 100644
--- a/renderdoc/api/replay/renderdoc_replay.h
+++ b/renderdoc/api/replay/renderdoc_replay.h
@@ -1030,7 +1030,7 @@ bucket when the pixel values are divided between ``minval`` and ``maxval``.
:rtype: ShaderDebugTrace
)");
virtual ShaderDebugTrace *DebugMeshletVertex(const rdcfixedarray<uint32_t, 3> &groupid,
- const rdcfixedarray<uint32_t, 3> &threadid) = 0;
+ const rdcfixedarray<uint32_t, 3> &threadid) = 0;
DOCUMENT(R"(Continue a shader's debugging with a given shader debugger instance. This will run an
implementation defined number of steps and then return those steps in a list. This may be a fixed
diff --git a/renderdoc/core/image_viewer.cpp b/renderdoc/core/image_viewer.cpp
index 9066689..ddc3ec2 100644
--- a/renderdoc/core/image_viewer.cpp
+++ b/renderdoc/core/image_viewer.cpp
@@ -358,7 +358,7 @@ public:
return new ShaderDebugTrace();
}
ShaderDebugTrace *DebugMeshletVertex(uint32_t eventId, const rdcfixedarray<uint32_t, 3> &groupid,
- const rdcfixedarray<uint32_t, 3> &threadid)
+ const rdcfixedarray<uint32_t, 3> &threadid)
{
return new ShaderDebugTrace();
}
diff --git a/renderdoc/core/replay_proxy.cpp b/renderdoc/core/replay_proxy.cpp
index 7c18ce5..249c317 100644
--- a/renderdoc/core/replay_proxy.cpp
+++ b/renderdoc/core/replay_proxy.cpp
@@ -1686,9 +1686,9 @@ ShaderDebugTrace *ReplayProxy::DebugThread(uint32_t eventId,
template <typename ParamSerialiser, typename ReturnSerialiser>
ShaderDebugTrace *ReplayProxy::Proxied_DebugMeshletVertex(ParamSerialiser ¶mser,
- ReturnSerialiser &retser, uint32_t eventId,
- const rdcfixedarray<uint32_t, 3> &groupid,
- const rdcfixedarray<uint32_t, 3> &threadid)
+ ReturnSerialiser &retser, uint32_t eventId,
+ const rdcfixedarray<uint32_t, 3> &groupid,
+ const rdcfixedarray<uint32_t, 3> &threadid)
{
const ReplayProxyPacket expectedPacket = eReplayProxy_DebugMeshletVertex;
ReplayProxyPacket packet = eReplayProxy_DebugMeshletVertex;
@@ -1716,8 +1716,8 @@ ShaderDebugTrace *ReplayProxy::Proxied_DebugMeshletVertex(ParamSerialiser ¶m
}
ShaderDebugTrace *ReplayProxy::DebugMeshletVertex(uint32_t eventId,
- const rdcfixedarray<uint32_t, 3> &groupid,
- const rdcfixedarray<uint32_t, 3> &threadid)
+ const rdcfixedarray<uint32_t, 3> &groupid,
+ const rdcfixedarray<
|
Code formatting check
Process completed with exit code 1.
|