feat: group new topic page #320

y-young · 2023-01-29T03:20:22Z

close #235

http://localhost:5173/group/sandbox/new_topic
https://pr-320-sites--bangumi-next.netlify.app/group/sandbox/new_topic

由于发帖页面的没有继承小组页面的通用布局，因此调整了一下目录结构，将原来 /group/[name] 里的页面移到了 /group/[name]/index 目录里
加入小组的按钮应该是一个通用的按钮类型，design 包里暂未实现，且目前的封装较为混乱，不少地方重复用了自定义样式，打算另开 PR 整理一下，正在同设计师讨论
合并所有已拆分的前置 PR

Textarea should have both left and right padding. Textarea handle should fit into container rounded corner.

github-actions · 2023-01-29T03:22:58Z

Preview Deployment

Storybook https://pr-320-storybook--bangumi-next.netlify.app

Sites https://pr-320-sites--bangumi-next.netlify.app

codecov · 2023-01-29T03:27:22Z

Codecov Report

Base: 88.81% // Head: 88.70% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (617fa12) compared to base (491430e).
Patch coverage: 89.92% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   88.81%   88.70%   -0.12%     
==========================================
  Files          86       88       +2     
  Lines        4874     5019     +145     
  Branches      517      529      +12     
==========================================
+ Hits         4329     4452     +123     
- Misses        545      567      +22

Impacted Files	Coverage Δ
...ges/index/group/[name]/components/NewTopicForm.tsx	`78.43% <78.43%> (ø)`
...bsite/src/pages/index/group/[name]/index/index.tsx	`93.75% <93.75%> (ø)`
...ges/website/src/pages/index/group/[name]/index.tsx	`100.00% <100.00%> (+6.45%)`	⬆️
...ite/src/pages/index/group/[name]/index/members.tsx	`96.20% <100.00%> (ø)`
...e/src/pages/index/group/components/GroupLayout.tsx	`100.00% <100.00%> (ø)`
...c/pages/index/group/components/GroupNavigation.tsx	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

So that react-hook-form can focus the field when there's an error.

To ease the use with react-hook-form

trim21 · 2023-01-29T06:52:12Z

如果觉得合并进来不应该是一个commit的话直接分成几个PR比较好吧。

登录的问题等着跟sai老板商量一下sso...

y-young · 2023-01-29T07:57:56Z

如果觉得合并进来不应该是一个commit的话直接分成几个PR比较好吧。

主要这些都是跟这个 PR 关联的一些前置重构和修复，如果拆的话不就得多出三四个额外的 PR？

不明白一个 PR 产生多个 commit 有什么问题……

Ayase-252 · 2023-01-29T09:31:01Z

一个 PR 尽量只干一件事情，更小的 PR 会更好 review 一点

y-young · 2023-01-29T09:35:24Z

我的习惯是维护一个整洁的 commit 历史，然后就可以按 commit review。

那我看看再拆两个 PR 出来吧……

按我的理解每个 commit 都是做一件事，如果每个 PR 也只做一件事的话就得有 6 个 PR

fix: styles refactor: clean up styles

y-young · 2023-02-12T14:15:09Z

设计稿里把小组的右栏宽度改窄了，发帖按钮的样式也改了，这里先按新的做了，其他的等另外的 PR

trim21

没检查用户是否登录？

y-young · 2023-02-13T06:19:28Z

没检查用户是否登录？

维基编辑页也没检查吧，等于这里也是交给后端做了，前端检查后面跟权限一起做吧？

trim21 · 2023-02-13T06:21:53Z

维基编辑页也没检查吧，等于这里也是交给后端做了，前端检查后面跟权限一起做吧？

那分成不同的pr后面再加上吧。

顺便做个某些路由下未登录时转跳登录页面，登录成功后再转跳回来的功能。

y-young · 2023-02-13T06:22:24Z

登录成功后再转跳回来的功能。

你提醒我了，这个之前打算做的b38

trim21 · 2023-02-13T06:27:37Z

功能看起来ok，代码等其他人review了

trim21 · 2023-02-13T06:28:56Z

还需要根据设计稿更新一下小组信息这个组件 🤔

trim21 · 2023-02-13T06:34:06Z

左右宽度跟设计稿不太一样，是要放在另外的PR？

y-young · 2023-02-13T06:34:59Z

左右宽度跟设计稿不太一样，是要放在另外的PR？

是，我上面说了，做的过程中设计稿改了，但是小组的左右栏布局和维基编辑页是一样的，设计稿里貌似还没改完

FoundTheWOUT · 2023-02-13T07:29:55Z

y-young · 2023-02-13T07:37:45Z

你是说调整 textarea 大小吗？我觉得这个场景下布局基本都会被破坏掉，尤其现在边框是加在编辑器上而不是 textarea 上，反正我试了好几次都没有找到合适的解决方法，你们谁要是有兴趣可以试着修一修 🥲

FoundTheWOUT · 2023-02-13T07:42:24Z

没有找到合适的解决方法

可以

不允许设置宽度
控制最小/最大宽度

FoundTheWOUT · 2023-02-13T07:43:42Z

frontend/packages/design/components/EditorForm/style/index.less

Line 14 in 66efafd

z-index: 9999;

@cokemine 当初这里是为啥要 9999，现在会导致覆盖掉了Header，Header是5000

y-young · 2023-02-13T07:45:28Z

可以

不允许设置宽度

控制最小/最大宽度

另开 Issue 或 PR 讨论吧，这块坑挺多的，组件那里在写小组讨论页的时候把宽度写死了还没改
当然如果不允许调整宽度就没有这些问题了（

FoundTheWOUT · 2023-02-13T07:53:57Z

另开 Issue 或 PR 讨论吧，这块坑挺多的，组件那里在写小组讨论页的时候把宽度写死了还没改当然如果不允许调整宽度就没有这些问题了（

确实，感觉还涉及到 EditorForm 和 Form 的问题

packages/website/src/pages/index/group/[name]/new_topic/index.tsx

cokemine · 2023-02-13T08:42:35Z

应该是当时被其他的给盖住了。就直接设了9999，调成5000以内应该不会有啥问题

cokemine · 2023-02-13T08:45:32Z

可以

不允许设置宽度

控制最小/最大宽度

另开 Issue 或 PR 讨论吧，这块坑挺多的，组件那里在写小组讨论页的时候把宽度写死了还没改当然如果不允许调整宽度就没有这些问题了（

主要是为了契合原站逻辑，如果直接固定宽度的话这个应该还可以简化一些，为了可以自由调整宽度当时这个编辑框的写法也是挺奇怪的，也没有考虑到上面可能还一个框要跟着动（

FoundTheWOUT · 2023-02-13T12:19:02Z

额。。merge 了，还想让 @Ayase-252 看下的（尴尬

y-young added 4 commits January 29, 2023 11:06

fix(Editor): pass down extra props & fix font size

675b9d3

refactor: extract group info component

5c0783f

feat: group new topic page (WIP)

d69763f

fix(Editor): textarea padding

76c05b2

Textarea should have both left and right padding. Textarea handle should fit into container rounded corner.

pull-request-size bot added the size/L label Jan 29, 2023

fix: test

b8a9b2c

y-young added 2 commits January 29, 2023 13:18

refactor(Editor): forward textarea ref

47050bd

So that react-hook-form can focus the field when there's an error.

refactor(Editor): rename content prop to value

ebe81e5

To ease the use with react-hook-form

trim21 mentioned this pull request Jan 29, 2023

Tracking Issue: 发帖/回帖 #235

Closed

2 tasks

feat: create new group topic (finished)

502b8f6

pull-request-size bot added size/XL and removed size/L labels Jan 29, 2023

Merge branch 'master' into feat/group-new-topic

66a1232

pull-request-size bot added size/L and removed size/XL labels Feb 1, 2023

y-young added 2 commits February 1, 2023 12:01

fix: editor width

d086337

feat: GroupNavigation component

8f7b752

pull-request-size bot added size/XL and removed size/L labels Feb 1, 2023

y-young added 4 commits February 8, 2023 17:34

Merge branch 'master' into feat/group-new-topic

a574bc2

fix: fill in group navigation links

a4fb2d7

feat: show validation error

82b927c

fix: styles refactor: clean up styles

fix: naive responsive design

7a8c5cf

pull-request-size bot removed the size/XL label Feb 8, 2023

mergify bot added the waiting-review label Feb 12, 2023

trim21 reviewed Feb 13, 2023

View reviewed changes

trim21 requested a review from a team February 13, 2023 06:29

FoundTheWOUT reviewed Feb 13, 2023

View reviewed changes

packages/website/src/pages/index/group/[name]/new_topic/index.tsx Show resolved Hide resolved

FoundTheWOUT mentioned this pull request Feb 13, 2023

Layout 布局 #360

Open

FoundTheWOUT approved these changes Feb 13, 2023

View reviewed changes

mergify bot merged commit 819a05e into bangumi:master Feb 13, 2023

mergify bot added waiting-opened-48h PR will be merged by bot after it's opened 48h and removed waiting-review labels Feb 13, 2023

This was referenced Feb 13, 2023

fix: EditorForm z-index #361

Closed

feat: BBcode editor disable horizontal resizing #363

Merged

y-young deleted the feat/group-new-topic branch February 14, 2023 06:50

trim21 mentioned this pull request Feb 14, 2023

ci: require 2 approval to auto-merging #367

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: group new topic page #320

feat: group new topic page #320

y-young commented Jan 29, 2023 •

edited by trim21

Loading

github-actions bot commented Jan 29, 2023 •

edited

Loading

codecov bot commented Jan 29, 2023 •

edited

Loading

trim21 commented Jan 29, 2023 •

edited

Loading

y-young commented Jan 29, 2023

Ayase-252 commented Jan 29, 2023

y-young commented Jan 29, 2023 •

edited

Loading

y-young commented Feb 12, 2023

trim21 left a comment

y-young commented Feb 13, 2023

trim21 commented Feb 13, 2023 •

edited

Loading

y-young commented Feb 13, 2023

trim21 commented Feb 13, 2023

trim21 commented Feb 13, 2023

trim21 commented Feb 13, 2023

y-young commented Feb 13, 2023 •

edited

Loading

FoundTheWOUT commented Feb 13, 2023

y-young commented Feb 13, 2023

FoundTheWOUT commented Feb 13, 2023

FoundTheWOUT commented Feb 13, 2023

y-young commented Feb 13, 2023 •

edited

Loading

FoundTheWOUT commented Feb 13, 2023

cokemine commented Feb 13, 2023

cokemine commented Feb 13, 2023

FoundTheWOUT commented Feb 13, 2023

feat: group new topic page #320

feat: group new topic page #320

Conversation

y-young commented Jan 29, 2023 • edited by trim21 Loading

github-actions bot commented Jan 29, 2023 • edited Loading

Preview Deployment

codecov bot commented Jan 29, 2023 • edited Loading

Codecov Report

trim21 commented Jan 29, 2023 • edited Loading

y-young commented Jan 29, 2023

Ayase-252 commented Jan 29, 2023

y-young commented Jan 29, 2023 • edited Loading

y-young commented Feb 12, 2023

trim21 left a comment

Choose a reason for hiding this comment

y-young commented Feb 13, 2023

trim21 commented Feb 13, 2023 • edited Loading

y-young commented Feb 13, 2023

trim21 commented Feb 13, 2023

trim21 commented Feb 13, 2023

trim21 commented Feb 13, 2023

y-young commented Feb 13, 2023 • edited Loading

FoundTheWOUT commented Feb 13, 2023

y-young commented Feb 13, 2023

FoundTheWOUT commented Feb 13, 2023

FoundTheWOUT commented Feb 13, 2023

y-young commented Feb 13, 2023 • edited Loading

FoundTheWOUT commented Feb 13, 2023

cokemine commented Feb 13, 2023

cokemine commented Feb 13, 2023

FoundTheWOUT commented Feb 13, 2023

y-young commented Jan 29, 2023 •

edited by trim21

Loading

github-actions bot commented Jan 29, 2023 •

edited

Loading

codecov bot commented Jan 29, 2023 •

edited

Loading

trim21 commented Jan 29, 2023 •

edited

Loading

y-young commented Jan 29, 2023 •

edited

Loading

trim21 commented Feb 13, 2023 •

edited

Loading

y-young commented Feb 13, 2023 •

edited

Loading

y-young commented Feb 13, 2023 •

edited

Loading