ci: require 2 approval to auto-merging #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview DeploymentSites https://pr-367-sites--bangumi-next.netlify.app Storybook https://pr-367-storybook--bangumi-next.netlify.app |
Codecov ReportBase: 88.14% // Head: 88.14% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 88 88
Lines 5062 5062
Branches 530 530
=======================================
Hits 4462 4462
Misses 600 600 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
trim21
changed the title
trim21
changed the title
|
@trim21 this pull request is now in conflict 😩 |
Ayase-252
reviewed
Feb 15, 2023
|
有新commit的情况下 approved-reviews-by 居然不会重置 - - |
|
|
你approve一下我试试（ |
Ayase-252
previously approved these changes
Feb 15, 2023
|
看起来OK |
Ayase-252
approved these changes
Feb 15, 2023
mergify
bot
added
waiting-opened-48h
mergify
bot
added
waiting-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub branch protection rule 没有修改，仍然是 1 个approval，只是修改了 bot 的自动合并条件。
避免 #320 (comment)