feat: add node_urls parameter to bzlmod toolchain in the node extension
#3763
Conversation
redsun82
requested review from
mattem,
gregmagolan,
alexeagle and
jbedard
as code owners
This patches `rules_nodejs` with the contents of bazel-contrib/rules_nodejs#3763 in order to allow specifying a mirror for nodejs, as nodejs.org has hit us with intermittent downtimes.
The conflict check was not comparing the `include_headers` attribute. Now the check will always compare all attributes of the declared toolchains, even if adding new ones in the future.
|
@jbedard thanks for the review. While going over the code again I figured there was also a problem in the existing conflict check, in that it didn't check a difference on the |
|
Are there any tests in the WORKSPACE version that can maybe be copied for the bzlmod extension? |
|
@jbedard I'll try to take a quick look. By the way: CI failed on a temporary nodejs.org failure, which is exactly the kind of problem I want to solve with this in my code base with mirrors 🙂 I didn't see any way I could rerun the check, but maybe I didn't look enough. On the other hand if I commit something more I'll get the reruns any way. |
|
@jbedard any chance you could take another look at this PR please? |
|
Sorry I forgot about this. If @redsun82 doesn't respond maybe you can update this? I assume my latest suggestion is easy enough, and would have saved me more time trying to remember what this PR is doing that I think it's worth it 😅 |
jbedard
changed the title
node_urls parameter to bzlmod toolchain in the node extensionnode_urls parameter to bzlmod toolchain in the node extension
Head branch was pushed to by a user without write access
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
node_urlscan be provided to add nodejs mirrors to theWORKFLOWbased setup, but the same can't be done when using bzlmod.Issue Number: N/A
What is the new behavior?
When using bzlmod,
node_urlscan be provided to thetoolchaintag class in thenodeextension, behaving just like theWORKFLOWcounterpart.Does this PR introduce a breaking change?
Other information