Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: add nodejs mirror #16822

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Bazel: add nodejs mirror #16822

merged 2 commits into from
Jun 24, 2024

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Jun 24, 2024

This patches rules_nodejs with the contents of bazel-contrib/rules_nodejs#3763 in order to allow specifying a mirror for nodejs, as nodejs.org has hit us with intermittent downtimes. The mirror added is from dotsrc.org (formerly SunSITE.dk).

This patches `rules_nodejs` with the contents of
bazel-contrib/rules_nodejs#3763
in order to allow specifying a mirror for nodejs, as nodejs.org has
hit us with intermittent downtimes.
@redsun82 redsun82 requested a review from a team as a code owner June 24, 2024 15:01
module(
name = "rules_nodejs",
- version = "0.0.0",
+ version = "6.2.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if anyone asks, this doesn't need to updated. Actually this whole patch is unneeded, the MODULE.bazel file present in the downloaded module is not used, the one that is used is the copy in the registry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I left the patch as it's copied from the bazel central registry... but I could remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and did that

Copy link
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@redsun82 redsun82 merged commit d2a00fa into main Jun 24, 2024
19 checks passed
@redsun82 redsun82 deleted the redsun82/nodejs-mirror branch June 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants