Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1.0]Improve error message for concurrent modification #17323

Closed
wants to merge 2 commits into from
Closed

[6.1.0]Improve error message for concurrent modification #17323

wants to merge 2 commits into from

Conversation

ShreeM01
Copy link
Contributor

Improve the error message logged when concurrent modifications occur and --experimental_guard_against_concurrent_changes is set.

Closes #17174.

PiperOrigin-RevId: 501012999
Change-Id: Id661ff2e5f98173323ebecb75b5e9825c8e0491e

Improve the error message logged when concurrent modifications
occur and --experimental_guard_against_concurrent_changes is set.

Closes #17174.

PiperOrigin-RevId: 501012999
Change-Id: Id661ff2e5f98173323ebecb75b5e9825c8e0491e
@google-cla
Copy link

google-cla bot commented Jan 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tbaing
Copy link
Contributor

tbaing commented Jan 27, 2023

It wasn't obvious to me how to rebase this PR to pick up my email address after updating my settings to show it in commit messages, so I created #17350 to replace this one. So that one can be merged and this one abandoned.

@ShreeM01 ShreeM01 closed this Jan 30, 2023
@ShreeM01 ShreeM01 reopened this Jan 31, 2023
@ShreeM01 ShreeM01 closed this Jan 31, 2023
@ShreeM01 ShreeM01 reopened this Jan 31, 2023
@tbaing
Copy link
Contributor

tbaing commented Jan 31, 2023

Would it be best to update the author email in the cherrypick commit here to use my Google email ([email protected])? I don't think I've got permissions to do that...

@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-user-response Awaiting a response from the author labels Feb 7, 2023
@keertk
Copy link
Member

keertk commented Feb 28, 2023

Closing - see #17396

@keertk keertk closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-response Awaiting a response from the author team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants