Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17173 improve error message #17350

Closed
wants to merge 2 commits into from

Conversation

tbaing
Copy link
Contributor

@tbaing tbaing commented Jan 27, 2023

Creating a new PR after updating my GitHub account's settings to show my @google.com email address in my commit header. This should have identical content to #17323, other than my email address.

tbaing and others added 2 commits January 9, 2023 18:53
Improve the error message logged when concurrent modifications
occur and --experimental_guard_against_concurrent_changes is set.
@tbaing tbaing requested a review from a team as a code owner January 27, 2023 20:08
@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 28, 2023
@tbaing
Copy link
Contributor Author

tbaing commented Jan 30, 2023

Hmm, given the merge conflict it looks like maybe these changes already merged under #17323 but the PR was still open due to the missing CLA (since the commit listed my GitHub email rather than my Google email as the author)?

It looks like this can be abandoned, but I'd appreciate confirmation of that from a maintainer since I hadn't thought #17323 had been merged.

@coeuvre
Copy link
Member

coeuvre commented Jan 31, 2023

#17323 wasn't merged into 6.1. The merge conflict is because this PR is comparing against master branch not release-6.1.0. Can you please update the PR?

@tbaing tbaing changed the base branch from master to release-6.1.0 January 31, 2023 17:46
@tbaing tbaing requested a review from ShreeM01 as a code owner January 31, 2023 17:46
@tbaing tbaing changed the base branch from release-6.1.0 to master January 31, 2023 17:47
@tbaing
Copy link
Contributor Author

tbaing commented Jan 31, 2023

Just updating the PR to target the 6.1.0 branch didn't work because then it tries to pull in other commits. Might the best solution be for @kshyanashree to update the author email in the cherrypick commit in #17323 to use my Google email ([email protected])?

@ShreeM01
Copy link
Contributor

Closing this PR because it’s already merged in the master.

@ShreeM01 ShreeM01 closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants