Ignore transitive cppmap files from dotd files #21832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious if someone who knows this area better has a better solution in mind for this! |
github-actions
bot
added
team-Rules-CPP
|
@lberki curious to hear your thoughts here. an alternative would be to always propagate all cppmap files, but I would think that would be undesirable for other reasons like the command line exploding |
keith
force-pushed
the
ks/ignore-transitive-cppmap-files-from-dotd-files
branch
from
bf8a7eb to
887ed5d
Compare
|
@lberki can you take a look or recommend someone else who should review? |
|
@pzembrod could you take a look? 🙏 |
|
@pzembrod can you help direct this one? this blocks llvm's upgrade to 7.x |
trybka
approved these changes
Jul 25, 2024
|
@bazel-io fork 7.3.0 |
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jul 26, 2024
When clang generates dotd files when using `-fmodule-map-file` any `extern module` directives in the modulemap are included in the dotd file if they exist. The result of this was that with sandboxing disabled the dotd file included transitive cppmap files that weren't in its input set, resulting in build failures. This change excludes those instead since they're not required as evidence by the fact that with sandboxing enabled they are not part of the input set. Fixes bazelbuild#21592 Closes bazelbuild#21832. PiperOrigin-RevId: 656382428 Change-Id: I4bc9802884ce1bc66ceda65a602db8dffbd1d9ea
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
When clang generates dotd files when using `-fmodule-map-file` any `extern module` directives in the modulemap are included in the dotd file if they exist. The result of this was that with sandboxing disabled the dotd file included transitive cppmap files that weren't in its input set, resulting in build failures. This change excludes those instead since they're not required as evidence by the fact that with sandboxing enabled they are not part of the input set. Fixes #21592 Closes #21832. PiperOrigin-RevId: 656382428 Change-Id: I4bc9802884ce1bc66ceda65a602db8dffbd1d9ea Commit ad53147 Co-authored-by: Keith Smiley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clang generates dotd files when using
-fmodule-map-fileanyextern moduledirectives in the modulemap are included in the dotd file if they exist. The result of this was that with sandboxing disabled the dotd file included transitive cppmap files that weren't in its input set, resulting in build failures. This change excludes those instead since they're not required as evidence by the fact that with sandboxing enabled they are not part of the input set.Fixes #21592