[7.3.0] Ignore transitive cppmap files from dotd files #23122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clang generates dotd files when using `-fmodule-map-file` any `extern module` directives in the modulemap are included in the dotd file if they exist. The result of this was that with sandboxing disabled the dotd file included transitive cppmap files that weren't in its input set, resulting in build failures. This change excludes those instead since they're not required as evidence by the fact that with sandboxing enabled they are not part of the input set. Fixes bazelbuild#21592 Closes bazelbuild#21832. PiperOrigin-RevId: 656382428 Change-Id: I4bc9802884ce1bc66ceda65a602db8dffbd1d9ea
bazel-io
added
team-Rules-CPP
trybka
previously approved these changes
Jul 26, 2024
iancha1992
dismissed
trybka’s stale review
Googler is needed to review when merging to a release branch
|
@trybka can you stamp again? |
Wyverald
approved these changes
Jul 26, 2024
Merged
via the queue into
bazelbuild:release-7.3.0
with commit Jul 26, 2024
0fa02b9
52 checks passed
|
thanks! |
github-actions
bot
removed
the
awaiting-review
asedeno
added a commit
to asedeno/envoy
that referenced
this pull request
Oct 8, 2024
CodeQL is running into issues with the layering_check feature with absl. ``` .../external/com_google_absl/absl/strings/BUILD.bazel:34:11: Compiling absl/strings/string_view.cc failed: undeclared inclusion(s) in rule '@com_google_absl//absl/strings:string_view': this rule is missing dependency declarations for the following files included by 'absl/strings/string_view.cc': 'bazel-out/k8-fastbuild/bin/external/com_google_absl/absl/meta/type_traits.cppmap' 'bazel-out/k8-fastbuild/bin/external/com_google_absl/absl/base/raw_logging_internal.cppmap' ``` Turning off the layering check seems to help. Bazel 7.3+ might help, but we're not there yet: bazelbuild/bazel#21592 bazelbuild/bazel#23122 Signed-off-by: Alejandro R. Sedeño <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clang generates dotd files when using
-fmodule-map-fileanyextern moduledirectives in the modulemap are included in the dotd file if they exist. The result of this was that with sandboxing disabled the dotd file included transitive cppmap files that weren't in its input set, resulting in build failures. This change excludes those instead since they're not required as evidence by the fact that with sandboxing enabled they are not part of the input set.Fixes #21592
Closes #21832.
PiperOrigin-RevId: 656382428
Change-Id: I4bc9802884ce1bc66ceda65a602db8dffbd1d9ea
Commit ad53147