Kotlin language version is not read correctly in newer rules_kotlin versions #7114
Assignees
Labels
awaiting-maintainer
Awaiting review from Bazel team on issues
lang: kotlin
Kotlin rules integration
product: IntelliJ
IntelliJ plugin
type: bug
Comments
jdai8
added
awaiting-maintainer
jdai8
added a commit
to jdai8/intellij
that referenced
this issue
Dec 4, 2024
Fixes bazelbuild#7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72
jdai8
added a commit
to jdai8/intellij
that referenced
this issue
Dec 4, 2024
Fixes bazelbuild#7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72
iancha1992
added
lang: kotlin
tpasternak
pushed a commit
that referenced
this issue
Dec 5, 2024
Fixes #7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this issue
Dec 6, 2024
Fixes bazelbuild#7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this issue
Dec 6, 2024
Fixes bazelbuild#7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72
mai93
added a commit
that referenced
this issue
Dec 6, 2024
* fix: Sync failure after non-fatal bazel failure (#7119) * Fix reading of _kt_toolchain attribute (#7115) Fixes #7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72 * fix: Kotlin toolchain detection (#7122) It has been accidentally removed here a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124 * doc: Update changelog for hotfix * Update CHANGELOG --------- Co-authored-by: Jack Dai <[email protected]> Co-authored-by: Mai Hussien <[email protected]>
mai93
added a commit
that referenced
this issue
Dec 6, 2024
* fix: Sync failure after non-fatal bazel failure (#7119) * Fix reading of _kt_toolchain attribute (#7115) Fixes #7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72 * fix: Kotlin toolchain detection (#7122) It has been accidentally removed here a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124 * doc: Update changelog for hotfix * Update CHANGELOG --------- Co-authored-by: Jack Dai <[email protected]> Co-authored-by: Mai Hussien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug:
bazelbuild/rules_kotlin#1157 removes legacy struct providers from rules_kotlin. #6394 changes the IntelliJ plugin to read the new toolchain provider, however this doesn't seem to be working for us.
I needed to make some changes to read these correctly and can put up a PR.
However, I saw that the change to use the
_kt_toolchainattribute was reverted here. a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117Was this change intentional? I see some Google commits with mentions of upcoming toolchain changes as well, so curious what the current status of this is.
Which category does this issue belong to?
No response
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Use rules_kotlin 2.0.0, load it in IntelliJ and observe that the Kotlin language version is not set.
Which Intellij IDE are you using? Please provide the specific version.
IntelliJ 2024.3
What programming languages and tools are you using? Please provide specific versions.
Kotlin
What Bazel plugin version are you using?
Built from source at 353dac8
Have you found anything relevant by searching the web?
N/A
Any other information, logs, or outputs that you want to share?
N/A
The text was updated successfully, but these errors were encountered: