fix: Kotlin toolchain detection #7122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been accidentally removed here bazelbuild@a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124
github-actions
bot
added
the
awaiting-review
ujohnny
approved these changes
Dec 5, 2024
github-actions
bot
removed
the
awaiting-review
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this pull request
Dec 6, 2024
It has been accidentally removed here bazelbuild@a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this pull request
Dec 6, 2024
It has been accidentally removed here bazelbuild@a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124
mai93
added a commit
that referenced
this pull request
Dec 6, 2024
* fix: Sync failure after non-fatal bazel failure (#7119) * Fix reading of _kt_toolchain attribute (#7115) Fixes #7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72 * fix: Kotlin toolchain detection (#7122) It has been accidentally removed here a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124 * doc: Update changelog for hotfix * Update CHANGELOG --------- Co-authored-by: Jack Dai <[email protected]> Co-authored-by: Mai Hussien <[email protected]>
mai93
added a commit
that referenced
this pull request
Dec 6, 2024
* fix: Sync failure after non-fatal bazel failure (#7119) * Fix reading of _kt_toolchain attribute (#7115) Fixes #7114. rules_kotlin has moved to using a special _kt_toolchain attribute, but it looks like the plugin is unable to properly read them. This commit fixes the output group `intellij-info-kt` (instead of `intellij-info-kotlin`) and adds rule kinds so that the plugin recognizes the toolchain. Change-Id: Iee168c264e81c17ffbb509045275faf0a88e1b72 * fix: Kotlin toolchain detection (#7122) It has been accidentally removed here a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124 * doc: Update changelog for hotfix * Update CHANGELOG --------- Co-authored-by: Jack Dai <[email protected]> Co-authored-by: Mai Hussien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been accidentally removed here
a88c6db#diff-7e834e0a725805ad4dfd127ba905e50964c78307ddb756da99d15a0a1ea28a46L1117-R1124
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change