105 UI #268
105 UI #268
Conversation
| window.onbeforeunload = (event) => { | ||
| event.preventDefault(); | ||
| if (uploadTasks.size !== 0) { | ||
| event.returnValue = 'Your file has not finished uploading'; |
There was a problem hiding this comment.
This only results in a custom message in Safari; there aren't ways to add custom messages for Firefox and Chrome.
I'm actually not able to replicate this on all files, Tamsin! I've navigated within the app when uploading two test files yesterday, and neither have finished uploading to Firestore, from what I can see. Neither xAVhAuWyNLASZ0xZLB0B nor cbR57... are in the uploads folder for our admin user. Screenshots of the associated transcripts are below; these are stuck on
On a separate note, ideally these should probably have |
Is your Pull Request request related to another issue in this repository ?
See #105 in Storybook
Describe what the PR does
Adds prompt if user tries to navigate away from DPE while media is uploadingsee Preserve upload task progress when navigating in the app #284State whether the PR is ready for review or whether it needs extra work
Ready
Additional context
Please review with the related Storybook PR to see all of the fixes for the relevant issue.
We don't have options to customise the alerts / prompts, and so I have not been able to implement Ngan-Thi's designs exactly for these. We can only customise strings for the prompt message when users try to click links during uploads, and we only have custom string support on IE for the alert when the user tries to close the window.
To test: