Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

105 transcript improvements #106

Merged
merged 6 commits into from
Jun 10, 2021
Merged

105 transcript improvements #106

merged 6 commits into from
Jun 10, 2021

Conversation

allishultes
Copy link
Contributor

@allishultes allishultes commented May 27, 2021 •
edited
Loading

Is your Pull Request request related to another issue in this repository ?

Fixes #105

Describe what the PR does

  • Removes the yet-to-be-implemented "cancel upload" design from the transcript cards
  • Fixes the in-progress messages on the transcript cards
  • Changes the "save" button on the transcript form to "upload"
  • Returns an error card if a job status is error or fail

State whether the PR is ready for review or whether it needs extra work

Ready

Additional context

Please review with the related Firebase PR to see all fixes for this ticket.

@allishultes allishultes mentioned this pull request May 27, 2021
Merged
2 tasks
@allishultes allishultes marked this pull request as ready for review May 27, 2021 09:17
@aniablaziak aniablaziak self-requested a review June 9, 2021 09:36
aniablaziak
aniablaziak approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@aniablaziak aniablaziak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

tamsingreen
tamsingreen approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@tamsingreen tamsingreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I assume leaving handleCancelItemUpload as a prop for TranscriptRow is necessary as we have a ticket to implement that?

@allishultes
Copy link
Contributor Author

Looks good! I assume leaving handleCancelItemUpload as a prop for TranscriptRow is necessary as we have a ticket to implement that?

Ah no, I think I should take that out, as that ticket might not make it in before trials. Thank you!

@allishultes allishultes merged commit b99f27a into master Jun 10, 2021
@allishultes allishultes deleted the 105-transcript-improvements branch June 10, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniablaziak aniablaziak aniablaziak approved these changes

@tamsingreen tamsingreen tamsingreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More improvements to transcribing UI
3 participants
@allishultes @tamsingreen @aniablaziak