Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

105 transcript improvements #106

Merged
merged 6 commits into from
Jun 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- I230 Updated design of the workspace: TranscriptRow component

## 1.26.0
- I92 Updates placeholder text and titles of project, transcript and programme script modals
- I92 Updates placeholder text and titles of project, transcript and programme script modals

## [ 1.27.0 ]
- I105 Updates TranscriptRow components
4 changes: 2 additions & 2 deletions src/TranscriptForm/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useEffect } from 'react';
import React, { useState } from 'react';
import PropTypes from 'prop-types';
import Form from 'react-bootstrap/Form';
import Button from 'react-bootstrap/Button';
Expand Down Expand Up @@ -105,7 +105,7 @@ const TranscriptForm = ({ ...props }) => {
</Form.Group>
<Modal.Footer>
<Button variant="primary" type="submit">
Save
Upload
</Button>
</Modal.Footer>
</Form>
Expand Down
4 changes: 2 additions & 2 deletions src/TranscriptRow/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const TranscriptRow = (props) => {
<FontAwesomeIcon icon={ faExclamationTriangle } /> This file will be automatically deleted after 60 days.
{typeof props.progress === 'number' ? (
<Row style={ { display: 'flex' } }>
<Col xs={ 8 } sm={ 9 }>
<Col xs={ 12 } sm={ 12 }>
<div style={ { display: 'flex' } }>
<span style={ { marginRight: '0.4rem' } }>Uploading...</span>
<ProgressBar
Expand Down Expand Up @@ -208,7 +208,7 @@ const TranscriptRow = (props) => {
card = DoneCard();
} else if (props.status === 'in-progress') {
card = InProgressCard();
} else if (props.status === 'error') {
} else if (props.status === 'error' || props.status === 'fail') {
card = ErrorCard();
} else if (props.status === 'uploading') {
card = UploadingCard();
Expand Down
6 changes: 3 additions & 3 deletions src/TranscriptRow/rows.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ const getExpiryDate = (createdDate) => {
};

const formatMessage = (message, mediaDuration) => {
if (message === 'Transcribing...') {
if (message === 'Transcribing...' || 'Stripping audio...' || 'Sending media to a Speech-to-Text service...') {
return mediaDuration ? `Transcribing, approx. ${ mediaDuration }` : message;
} else if (message === 'Stripping audio...' || 'Sending media to a Speech-to-Text service...') {
return `Preparing: ${ message }`;
}

// Will return queued message

return `Transcribing: ${ message }`;
};

Expand Down