Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate SwordWorld, SwordWorld2.0 and SwordWorld2.5 to Simplified Chinese #595

Merged
merged 20 commits into from
Feb 17, 2023

Conversation

asterson
Copy link
Contributor

Hello, I've added the SwordWorld、SwordWorld2.0 Simplified Chinese. I am not very familiar with GitHub, if you find any issues or have any suggestions, please let me know!

@asterson asterson marked this pull request as draft January 23, 2023 15:14
@asterson asterson marked this pull request as ready for review February 1, 2023 16:29
@asterson
Copy link
Contributor Author

asterson commented Feb 1, 2023

and also SwordWorld2.5!

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 95.42% // Head: 95.43% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fce5cb1) compared to base (de9959b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   95.42%   95.43%           
=======================================
  Files         326      329    +3     
  Lines       18401    18440   +39     
  Branches     4768     4768           
=======================================
+ Hits        17560    17599   +39     
  Misses        841      841           
Impacted Files Coverage Δ
lib/bcdice/game_system.rb 100.00% <100.00%> (ø)
...ice/game_system/SwordWorld2_0_SimplifiedChinese.rb 100.00% <100.00%> (ø)
...ice/game_system/SwordWorld2_5_SimplifiedChinese.rb 100.00% <100.00%> (ø)
...bcdice/game_system/SwordWorld_SimplifiedChinese.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ysakasin ysakasin changed the title Add SwordWorld、SwordWorld2.0 SimplifiedChinese Translate SwordWorld, SwordWorld2.0 and SwordWorld2.5 to Simplified Chinese Feb 17, 2023
@ysakasin ysakasin merged commit 17f2815 into bcdice:master Feb 17, 2023
@ysakasin
Copy link
Member

@asterson

Awesome!
Thank you translating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants