Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of little cleanup things #175

Merged
merged 55 commits into from
Sep 6, 2022
Merged

Lots of little cleanup things #175

merged 55 commits into from
Sep 6, 2022

Conversation

cycomachead
Copy link
Member

@cycomachead cycomachead commented Sep 1, 2022

See #172

  • do not store access/refresh tokens on login
  • fix changing a teacher's school
  • show admin users on the teachers index
  • refactor schools index
  • show pages sidebar on the dashboard
  • allow editing/deleting a school directly
  • cleanup a bunch of logic around selectize/school forms
  • remove some old db columns
  • rename the db columns on pages
  • lots of little code cleanup

@cycomachead
Copy link
Member Author

cycomachead commented Sep 5, 2022

Test cases to add:

  • [ ] test admins on Teachers#index
  • test teacher#edit shows the right school by default
  • ensure teacher#edit can update the right school
  • smoke+auth tests for schools #new, #index, #edit
  • ensure schools#show has the correct teachers count / list of teachers
  • explicit test case for changing a teacher's school (controller specs)

@cycomachead cycomachead mentioned this pull request Sep 6, 2022
5 tasks
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 95.28% // Head: 86.43% // Decreases project coverage by -8.85% ⚠️

Coverage data is based on head (8ddab67) compared to base (28e16d5).
Patch coverage: 81.37% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   95.28%   86.43%   -8.86%     
==========================================
  Files          18       18              
  Lines         509      538      +29     
==========================================
- Hits          485      465      -20     
- Misses         24       73      +49     
Impacted Files Coverage Δ
app/controllers/schools_controller.rb 70.00% <54.83%> (-26.16%) ⬇️
app/controllers/teachers_controller.rb 96.18% <89.13%> (-2.05%) ⬇️
app/controllers/application_controller.rb 100.00% <100.00%> (ø)
app/controllers/main_controller.rb 100.00% <100.00%> (ø)
app/controllers/pages_controller.rb 97.82% <100.00%> (ø)
app/controllers/sessions_controller.rb 100.00% <100.00%> (ø)
app/models/page.rb 100.00% <100.00%> (+3.84%) ⬆️
app/models/school.rb 91.48% <100.00%> (+2.12%) ⬆️
app/models/teacher.rb 85.24% <100.00%> (-0.24%) ⬇️
lib/csv_process.rb 15.21% <0.00%> (-73.92%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cycomachead cycomachead merged commit 204fe9a into master Sep 6, 2022
@cycomachead cycomachead deleted the school-edit-admin-fixes branch September 6, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant