-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of little cleanup things #175
Conversation
* selectize now uses JSON to store school data * sets the school_id on change * cleaned up code for generating options
Tests are definitely needed!
Test cases to add:
|
* cleanup setup for writing tables to fill in a form * fix creating a new school when updating a teacher * tidy the selectize setup around new schools
Codecov ReportBase: 95.28% // Head: 86.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 95.28% 86.43% -8.86%
==========================================
Files 18 18
Lines 509 538 +29
==========================================
- Hits 485 465 -20
- Misses 24 73 +49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
See #172