Code

Lots of little cleanup things#175

Code

Merged

cycomachead merged 55 commits intomasterbeautyjoy/BJC-Teacher-Tracker:masterfrom school-edit-admin-fixesbeautyjoy/BJC-Teacher-Tracker:school-edit-admin-fixesCopy head branch name to clipboardSep 6, 2022

+816-813

Commits

Commits on Sep 1, 2022

• patch omniauth

  cycomachead

  committed
  acb3cf3

• Add a db:import rake task

  cycomachead

  committed
  1ed3b98

• Do not store access/refresh tokens on login

  cycomachead

  committed
  6138db5

• run rubocop

  cycomachead

  committed
  f0ef9fa

Commits on Sep 2, 2022

• Remove all oauth tokens, and attr_encrypted from teacher logins

  cycomachead

  committed
  335bada

• School Selectize: Fix school_id and form fields

  Show description for f76aaaf
  cycomachead

  committed
  f76aaaf

Commits on Sep 5, 2022

• Show the current school first in the selectize dropdown

  cycomachead

  committed
  656008e

• use a wider base layout with a fixed nav

  cycomachead

  committed
  da7cd7b

• add margin for fixed nav

  cycomachead

  committed
  c238283

• Editing/Deleting/Viewing Schools now mostly works.

  Show description for 234121c
  cycomachead

  committed
  234121c

• Cleanup+fix teacher creation

  cycomachead

  committed
  4a9eb7d

• Protect against deleting schools with teachers

  cycomachead

  committed
  0b0a526

• Show admin users in a second table on teachers#index

  cycomachead

  committed
  7a632f7

• delete unneeded JS code!

  cycomachead

  committed
  019b4e3

• Improve teacher visible forms to include the sidebar

  cycomachead

  committed
  d7f2bc3

• Fix preventing schools deletion

  cycomachead

  committed
  3a06275

• Rename slug to URL, permissions to viewer_permissions

  cycomachead

  committed
  faf3c06

• tidy

  cycomachead

  committed
  7c17daf

Commits on Sep 6, 2022

• Improved datatables filtering and pagination

  cycomachead

  committed
  330374f

• cleanup JS

  cycomachead

  committed
  9d87907

• fix teachers allowed params

  cycomachead

  committed
  d4d8766

• rerun migrations

  cycomachead

  committed
  83baa3a

• Reorder code in teachers controller

  cycomachead

  committed
  83d8abc

• Minor cleanup of layoutes

  cycomachead

  committed
  05bd3df

• Cleanup

  cycomachead

  committed
  e0fc2cc

• fix typo in main_spec

  cycomachead

  committed
  0955279

• fix page validations function

  cycomachead

  committed
  c43132c

• replace to text referring to renamed columns

  cycomachead

  committed
  928183d

• Cleanup specs for changing display/text

  cycomachead

  committed
  04036b4

• reflect changed behavior of sessions destroy

  cycomachead

  committed
  ef17faa

• Fix the schools spec

  cycomachead

  committed
  c90b068

• Load fixtures in cucumber for consistency

  cycomachead

  committed
  ad84728

• fix some copy in test cases

  cycomachead

  committed
  d5c4088

• Admin + teacher cuke fixes

  Show description for a81d49a
  cycomachead

  committed
  a81d49a

• run rubocop

  cycomachead

  committed
  b3b7d28

• Fix weird school counter issues

  cycomachead

  committed
  aa64d9f

• Fix weird spec with emails

  cycomachead

  committed
  3a87875

• Fixup admin features / within steps

  cycomachead

  committed
  5b9315b

• Fix some weird failures with more unique data

  cycomachead

  committed
  ddf071b

• Fix bad find and replace in workflow

  cycomachead

  committed
  1b5b47c

• restore new page button on the pages index

  cycomachead

  committed
  efea955

• Fix name of field on pages edit

  cycomachead

  committed
  8f8764d

• Add some now required fields to the school factory

  cycomachead

  committed
  03b93b7

• Attempt to cleanup csv

  cycomachead

  committed
  3fec04c

• remove logging

  cycomachead

  committed
  c2b3f88

• Cleanup the form HTML

  cycomachead

  committed
  d484003

• fix some strings in tests, and the schools factory

  cycomachead

  committed
  622a325

• Comment out the CSV feature tests for now

  cycomachead

  committed
  f63773a

• Cleanup logic in school creation

  cycomachead

  committed
  2bf3919

• tidy code

  cycomachead

  committed
  d97e7a3

• try something else

  cycomachead

  committed
  081b943

• use .present? once more

  cycomachead

  committed
  61ad815

• fix more specs, load db seeds in rspec

  cycomachead

  committed
  a6f3fcd

• Fix more school creation to use IDs

  cycomachead

  committed
  8abe819

• rubocop

  cycomachead

  committed
  8ddab67